Issue #6697: catch _PyUnicode_AsString() errors in getattr() and setattr()

builtin functions.

diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index b4bdf119218d6869d55e2036f797b9297035b9b9..5d24000e843fd3541b01609a3f49447b6279a274 100644 (file)
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -479,6 +479,8 @@ class BuiltinTest(unittest.TestCase):
         self.assertRaises(TypeError, getattr, sys, 1, "foo")
         self.assertRaises(TypeError, getattr)
         self.assertRaises(AttributeError, getattr, sys, chr(sys.maxunicode))
+        # unicode surrogates are not encodable to the default encoding (utf8)
+        self.assertRaises(AttributeError, getattr, 1, "\uDAD1\uD51E")
 
     def test_hasattr(self):
         import sys

diff --git a/Objects/object.c b/Objects/object.c
index b0a54719a0a2a1e4ad22bc397f11e314f7cf9a67..a332c6c85e3a15c0b690bff6504447c9fbde185d 100644 (file)
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -799,8 +799,12 @@ PyObject_GetAttr(PyObject *v, PyObject *name)
        }
        if (tp->tp_getattro != NULL)
                return (*tp->tp_getattro)(v, name);
-       if (tp->tp_getattr != NULL)
-               return (*tp->tp_getattr)(v, _PyUnicode_AsString(name));
+       if (tp->tp_getattr != NULL) {
+               char *name_str = _PyUnicode_AsString(name);
+               if (name_str == NULL)
+                       return NULL;
+               return (*tp->tp_getattr)(v, name_str);
+       }
        PyErr_Format(PyExc_AttributeError,
                     "'%.50s' object has no attribute '%U'",
                     tp->tp_name, name);
@@ -840,7 +844,10 @@ PyObject_SetAttr(PyObject *v, PyObject *name, PyObject *value)
                return err;
        }
        if (tp->tp_setattr != NULL) {
-               err = (*tp->tp_setattr)(v, _PyUnicode_AsString(name), value);
+               char *name_str = _PyUnicode_AsString(name);
+               if (name_str == NULL)
+                       return -1;
+               err = (*tp->tp_setattr)(v, name_str, value);
                Py_DECREF(name);
                return err;
        }
@@ -1019,8 +1026,8 @@ PyObject_GenericGetAttr(PyObject *obj, PyObject *name)
        }
 
        PyErr_Format(PyExc_AttributeError,
-                    "'%.50s' object has no attribute '%.400s'",
-                    tp->tp_name, _PyUnicode_AsString(name));
+                    "'%.50s' object has no attribute '%U'",
+                    tp->tp_name, name);
   done:
        Py_DECREF(name);
        return res;