]> granicus.if.org Git - postgresql/commitdiff
Just noticed that use of 'volatile' in HPPA S_UNLOCK() was causing gcc
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 16 Feb 2001 23:50:40 +0000 (23:50 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 16 Feb 2001 23:50:40 +0000 (23:50 +0000)
to generate unnecessarily stupid code.  Tweak macro to describe a series
of store-constant ops, not store/load/store/load/store/load/store.

src/include/storage/s_lock.h

index 726c3645e564f7c00604bbf84d6effddd1668cc5..9cf73163d60779526a83f3ed31c472e20275d027 100644 (file)
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *       $Header: /cvsroot/pgsql/src/include/storage/s_lock.h,v 1.88 2001/02/10 04:07:25 tgl Exp $
+ *       $Header: /cvsroot/pgsql/src/include/storage/s_lock.h,v 1.89 2001/02/16 23:50:40 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -392,8 +392,10 @@ tas(volatile slock_t *lock)
 #define S_UNLOCK(lock) \
        do { \
                volatile slock_t *lock_ = (volatile slock_t *) (lock); \
-               lock_->sema[0] = lock_->sema[1] = \
-               lock_->sema[2] = lock_->sema[3] = -1; \
+               lock_->sema[0] = -1; \
+               lock_->sema[1] = -1; \
+               lock_->sema[2] = -1; \
+               lock_->sema[3] = -1; \
        } while (0)
 
 #define S_LOCK_FREE(lock)      ( *(int *) (((long) (lock) + 15) & ~15) != 0)