* libmisc/env.c, libmisc/age.c: Added splint annotations.

	* libmisc/age.c: Added brackets and parenthesis.
	* libmisc/age.c: Ignore the return value of fclose (file opened
	read-only)
	* libmisc/age.c: Ignore puts() return value.
	* libmisc/age.c: Use exit(EXIT_FAILURE) instead of exit(1).
	* libmisc/age.c: Avoid assignments in comparisons.

diff --git a/ChangeLog b/ChangeLog
index c9f058ef2244a91160ea0f78746b8c01000f3f02..439acc12e22dba0bb13df1dca8e1e1935d654a8e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2009-04-22  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * libmisc/env.c, libmisc/age.c: Added splint annotations.
+       * libmisc/age.c: Added brackets and parenthesis.
+       * libmisc/age.c: Ignore the return value of fclose (file opened
+       read-only)
+       * libmisc/age.c: Ignore puts() return value.
+       * libmisc/age.c: Use exit(EXIT_FAILURE) instead of exit(1).
+       * libmisc/age.c: Avoid assignments in comparisons.
+
 2009-04-22  Nicolas François  <nicolas.francois@centraliens.net>
 
        * lib/fputsx.c, lib/gshadow.c, lib/commonio.h: Added splint

diff --git a/libmisc/age.c b/libmisc/age.c
index d46abdc3c8b3c8a038c7c5876bda7b7d1c6c2786..12e6036eeccaaeacceef9faa96ebf6cd43df9e87 100644 (file)
--- a/libmisc/age.c
+++ b/libmisc/age.c
@@ -2,7 +2,7 @@
  * Copyright (c) 1989 - 1994, Julianne Frances Haugh
  * Copyright (c) 1996 - 1998, Marek Michałkiewicz
  * Copyright (c) 2001 - 2006, Tomasz Kłoczko
- * Copyright (c) 2008       , Nicolas François
+ * Copyright (c) 2008 - 2009, Nicolas François
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -53,7 +53,7 @@
  *     expire() calls /bin/passwd to change the user's password
  *     if it has expired.
  */
-int expire (const struct passwd *pw, const struct spwd *sp)
+int expire (const struct passwd *pw, /*@null@*/const struct spwd *sp)
 {
        int status;
        pid_t child;

diff --git a/libmisc/env.c b/libmisc/env.c
index e982f7314972976223ceb529d77a8b0d66228a7e..e2e42986f2d25b98efd0f69c401476777588314a 100644 (file)
--- a/libmisc/env.c
+++ b/libmisc/env.c
@@ -2,7 +2,7 @@
  * Copyright (c) 1989 - 1992, Julianne Frances Haugh
  * Copyright (c) 1996 - 1999, Marek Michałkiewicz
  * Copyright (c) 2003 - 2005, Tomasz Kłoczko
- * Copyright (c) 2008       , Nicolas François
+ * Copyright (c) 2008 - 2009, Nicolas François
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -46,7 +46,7 @@
  */
 #define NEWENVP_STEP 16
 size_t newenvc = 0;
-char **newenvp = NULL;
+/*@null@*/char **newenvp = NULL;
 extern char **environ;
 
 static const char *forbid[] = {
@@ -85,7 +85,7 @@ void initenv (void)
 }
 
 
-void addenv (const char *string, const char *value)
+void addenv (const char *string, /*@null@*/const char *value)
 {
        char *cp, *newstring;
        size_t i;