Fix error messages

Some messages related to foreign servers were reporting the server name
without quotes, or not at all; our style is to have all names be quoted,
and the server name already appears quoted in a few other messages, so
just add quotes and make them all consistent.

Remove an extra "s" in other messages (typos introduced by myself in
f56f8f8da6af).

diff --git a/src/backend/commands/foreigncmds.c b/src/backend/commands/foreigncmds.c
index 413ce3fcb66d64796605afd9f87ec816bfdbeaed..d7bc6e35f029cfa1fb4ce35e496455a78f2cff73 100644 (file)
--- a/src/backend/commands/foreigncmds.c
+++ b/src/backend/commands/foreigncmds.c
@@ -1184,7 +1184,7 @@ CreateUserMapping(CreateUserMappingStmt *stmt)
                {
                        ereport(NOTICE,
                                        (errcode(ERRCODE_DUPLICATE_OBJECT),
-                                        errmsg("user mapping for \"%s\" already exists for server %s, skipping",
+                                        errmsg("user mapping for \"%s\" already exists for server \"%s\", skipping",
                                                        MappingUserName(useId),
                                                        stmt->servername)));
 
@@ -1194,7 +1194,7 @@ CreateUserMapping(CreateUserMappingStmt *stmt)
                else
                        ereport(ERROR,
                                        (errcode(ERRCODE_DUPLICATE_OBJECT),
-                                        errmsg("user mapping for \"%s\" already exists for server %s",
+                                        errmsg("user mapping for \"%s\" already exists for server \"%s\"",
                                                        MappingUserName(useId),
                                                        stmt->servername)));
        }
@@ -1294,8 +1294,8 @@ AlterUserMapping(AlterUserMappingStmt *stmt)
        if (!OidIsValid(umId))
                ereport(ERROR,
                                (errcode(ERRCODE_UNDEFINED_OBJECT),
-                                errmsg("user mapping for \"%s\" does not exist for the server",
-                                               MappingUserName(useId))));
+                                errmsg("user mapping for \"%s\" does not exist for server \"%s\"",
+                                               MappingUserName(useId), stmt->servername)));
 
        user_mapping_ddl_aclcheck(useId, srv->serverid, stmt->servername);
 
@@ -1396,7 +1396,9 @@ RemoveUserMapping(DropUserMappingStmt *stmt)
                                         errmsg("server \"%s\" does not exist",
                                                        stmt->servername)));
                /* IF EXISTS, just note it */
-               ereport(NOTICE, (errmsg("server does not exist, skipping")));
+               ereport(NOTICE,
+                               (errmsg("server \"%s\" does not exist, skipping",
+                                               stmt->servername)));
                return InvalidOid;
        }
 
@@ -1409,13 +1411,13 @@ RemoveUserMapping(DropUserMappingStmt *stmt)
                if (!stmt->missing_ok)
                        ereport(ERROR,
                                        (errcode(ERRCODE_UNDEFINED_OBJECT),
-                                        errmsg("user mapping for \"%s\" does not exist for the server",
-                                                       MappingUserName(useId))));
+                                        errmsg("user mapping for \"%s\" does not exist for server \"%s\"",
+                                                       MappingUserName(useId), stmt->servername)));
 
                /* IF EXISTS specified, just note it */
                ereport(NOTICE,
-                               (errmsg("user mapping for \"%s\" does not exist for the server, skipping",
-                                               MappingUserName(useId))));
+                               (errmsg("user mapping for \"%s\" does not exist for server \"%s\", skipping",
+                                               MappingUserName(useId), stmt->servername)));
                return InvalidOid;
        }
 

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 8e4743d11015f6a6837d35376f1c9dc9238d4512..03daa252817cc156ad003b0a7d0ae242c91011d6 100644 (file)
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -8184,7 +8184,7 @@ addFkRecurseReferencing(List **wqueue, Constraint *fkconstraint, Relation rel,
        if (rel->rd_rel->relkind == RELKIND_FOREIGN_TABLE)
                ereport(ERROR,
                                (errcode(ERRCODE_WRONG_OBJECT_TYPE),
-                                errmsg("foreign keys constraints are not supported on foreign tables")));
+                                errmsg("foreign key constraints are not supported on foreign tables")));
 
        /*
         * If the referencing relation is a plain table, add the check triggers to
@@ -8572,7 +8572,7 @@ CloneFkReferencing(List **wqueue, Relation parentRel, Relation partRel)
        if (partRel->rd_rel->relkind == RELKIND_FOREIGN_TABLE)
                ereport(ERROR,
                                (errcode(ERRCODE_WRONG_OBJECT_TYPE),
-                                errmsg("foreign keys constraints are not supported on foreign tables")));
+                                errmsg("foreign key constraints are not supported on foreign tables")));
 
        /*
         * The constraint key may differ, if the columns in the partition are

diff --git a/src/test/regress/expected/foreign_data.out b/src/test/regress/expected/foreign_data.out
index 3dfe888410f9faf9fa8450fa590ce40841aeca8e..c81e4bda80757d7004c6e65b5e382a9b7835d45f 100644 (file)
--- a/src/test/regress/expected/foreign_data.out
+++ b/src/test/regress/expected/foreign_data.out
@@ -238,9 +238,9 @@ CREATE SERVER s1 FOREIGN DATA WRAPPER foo;
 COMMENT ON SERVER s1 IS 'foreign server';
 CREATE USER MAPPING FOR current_user SERVER s1;
 CREATE USER MAPPING FOR current_user SERVER s1;                                -- ERROR
-ERROR:  user mapping for "regress_foreign_data_user" already exists for server s1
+ERROR:  user mapping for "regress_foreign_data_user" already exists for server "s1"
 CREATE USER MAPPING IF NOT EXISTS FOR current_user SERVER s1; -- NOTICE
-NOTICE:  user mapping for "regress_foreign_data_user" already exists for server s1, skipping
+NOTICE:  user mapping for "regress_foreign_data_user" already exists for server "s1", skipping
 \dew+
                                                 List of foreign-data wrappers
     Name    |           Owner           | Handler |        Validator         | Access privileges | FDW options | Description 
@@ -578,7 +578,7 @@ CREATE USER MAPPING FOR current_user SERVER s1;             -- ERROR
 ERROR:  server "s1" does not exist
 CREATE USER MAPPING FOR current_user SERVER s4;
 CREATE USER MAPPING FOR user SERVER s4;                     -- ERROR duplicate
-ERROR:  user mapping for "regress_foreign_data_user" already exists for server s4
+ERROR:  user mapping for "regress_foreign_data_user" already exists for server "s4"
 CREATE USER MAPPING FOR public SERVER s4 OPTIONS ("this mapping" 'is public');
 CREATE USER MAPPING FOR user SERVER s8 OPTIONS (username 'test', password 'secret');    -- ERROR
 ERROR:  invalid option "username"
@@ -618,7 +618,7 @@ ERROR:  role "regress_test_missing_role" does not exist
 ALTER USER MAPPING FOR user SERVER ss4 OPTIONS (gotcha 'true'); -- ERROR
 ERROR:  server "ss4" does not exist
 ALTER USER MAPPING FOR public SERVER s5 OPTIONS (gotcha 'true');            -- ERROR
-ERROR:  user mapping for "public" does not exist for the server
+ERROR:  user mapping for "public" does not exist for server "s5"
 ALTER USER MAPPING FOR current_user SERVER s8 OPTIONS (username 'test');    -- ERROR
 ERROR:  invalid option "username"
 HINT:  Valid options in this context are: user, password
@@ -648,13 +648,13 @@ ERROR:  role "regress_test_missing_role" does not exist
 DROP USER MAPPING FOR user SERVER ss4;
 ERROR:  server "ss4" does not exist
 DROP USER MAPPING FOR public SERVER s7;                     -- ERROR
-ERROR:  user mapping for "public" does not exist for the server
+ERROR:  user mapping for "public" does not exist for server "s7"
 DROP USER MAPPING IF EXISTS FOR regress_test_missing_role SERVER s4;
 NOTICE:  role "regress_test_missing_role" does not exist, skipping
 DROP USER MAPPING IF EXISTS FOR user SERVER ss4;
-NOTICE:  server does not exist, skipping
+NOTICE:  server "ss4" does not exist, skipping
 DROP USER MAPPING IF EXISTS FOR public SERVER s7;
-NOTICE:  user mapping for "public" does not exist for the server, skipping
+NOTICE:  user mapping for "public" does not exist for server "s7", skipping
 CREATE USER MAPPING FOR public SERVER s8;
 SET ROLE regress_test_role;
 DROP USER MAPPING FOR public SERVER s8;                     -- ERROR