[ Backpatch to 7.3.X.]

If they're not, the below causes problems, as the foreign key is added
after the CHECK.  Cluster depends on the index name, so I thought it
wise to ensure all names are available, rather than leaving off the
CONSTRAINT "$n" portion for internally named constraints.

CREATE TABLE jkey (col integer primary key);
CREATE TABLE j (col integer REFERENCES jkey);
ALTER TABLE j ADD CHECK(col > 5);

This is a problem in 7.3 series as well as -Tip.

--
Rod Taylor <rbt@rbt.ca>

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 831c22b419bc7767a6facdbe09291ffeb67ed553..858faecc181b5a53509b700bf6f3f63aee0015be 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -22,7 +22,7 @@
  *
  *
  * IDENTIFICATION
- *       $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.305.2.6 2003/05/16 13:57:03 tgl Exp $
+ *       $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.305.2.7 2003/06/25 04:09:15 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5388,8 +5388,7 @@ dumpOneTable(Archive *fout, TableInfo *tbinfo, TableInfo *g_tblinfo)
                                if (actual_atts + j > 0)
                                        appendPQExpBuffer(q, ",\n    ");
 
-                               if (name[0] != '$')
-                                       appendPQExpBuffer(q, "CONSTRAINT %s ",
+                               appendPQExpBuffer(q, "CONSTRAINT %s ",
                                                                          fmtId(name));
                                appendPQExpBuffer(q, "CHECK (%s)", expr);
                        }