UnresolvedMemberExprs need lvalue-to-rvalue conversions during template

instantiations too.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@143016 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/TreeTransform.h b/lib/Sema/TreeTransform.h
index 59c132caccda97a5696597d83d19af03ef51e71d..7fb2d35c70671114dbe7433682207de8ab139f89 100644 (file)
--- a/lib/Sema/TreeTransform.h
+++ b/lib/Sema/TreeTransform.h
@@ -2145,6 +2145,13 @@ public:
     CXXScopeSpec SS;
     SS.Adopt(QualifierLoc);
 
+    if (BaseE && IsArrow) {
+      ExprResult BaseResult = getSema().DefaultLvalueConversion(BaseE);
+      if (BaseResult.isInvalid())
+        return ExprError();
+      BaseE = BaseResult.take();
+    }
+
     return SemaRef.BuildMemberReferenceExpr(BaseE, BaseType,
                                             OperatorLoc, IsArrow,
                                             SS, FirstQualifierInScope,

diff --git a/test/SemaCXX/warn-thread-safety-analysis.cpp b/test/SemaCXX/warn-thread-safety-analysis.cpp
index b4d44170fec33828188c2600f4c0073ac4966ebe..ff290198c019cddef2d69e2c061d34b3200e0d4d 100644 (file)
--- a/test/SemaCXX/warn-thread-safety-analysis.cpp
+++ b/test/SemaCXX/warn-thread-safety-analysis.cpp
@@ -1533,4 +1533,19 @@ namespace template_member_test {
 
   template struct IndirectLock<int>; // expected-note {{here}}
 
+  struct V {
+    void f(int);
+    void f(double);
+
+    Mutex m;
+    V *p GUARDED_BY(this->m);
+  };
+  template<typename U> struct W {
+    V v;
+    void f(U u) {
+      v.p->f(u); // expected-warning {{reading variable 'p' requires locking 'm'}}
+    }
+  };
+  template struct W<int>; // expected-note {{here}}
+
 }