Remove superfluous quotes and commas in dictionaries

fixes #6687

diff --git a/doc/3-monitoring-basics.md b/doc/3-monitoring-basics.md
index 82a3abfc70716a5c90ac407a107652221ae2a5a8..1bd1da4cde7e867a692ed0e521f6d11455d8e588 100644 (file)
--- a/doc/3-monitoring-basics.md
+++ b/doc/3-monitoring-basics.md
@@ -849,18 +849,18 @@ you can add a `vars` dictionary as shown for the `CheckCommand` object.
       command = [ SysconfDir + "/icinga2/scripts/mail-notification.sh" ]
 
       env = {
-        "NOTIFICATIONTYPE" = "$notification.type$"
-        "SERVICEDESC" = "$service.name$"
-        "HOSTALIAS" = "$host.display_name$",
-        "HOSTADDRESS" = "$address$",
-        "SERVICESTATE" = "$service.state$",
-        "LONGDATETIME" = "$icinga.long_date_time$",
-        "SERVICEOUTPUT" = "$service.output$",
-        "NOTIFICATIONAUTHORNAME" = "$notification.author$",
-        "NOTIFICATIONCOMMENT" = "$notification.comment$",
-       "HOSTDISPLAYNAME" = "$host.display_name$",
-        "SERVICEDISPLAYNAME" = "$service.display_name$",
-        "USEREMAIL" = "$user.email$"
+        NOTIFICATIONTYPE = "$notification.type$"
+        SERVICEDESC = "$service.name$"
+        HOSTALIAS = "$host.display_name$"
+        HOSTADDRESS = "$address$"
+        SERVICESTATE = "$service.state$"
+        LONGDATETIME = "$icinga.long_date_time$"
+        SERVICEOUTPUT = "$service.output$"
+        NOTIFICATIONAUTHORNAME = "$notification.author$"
+        NOTIFICATIONCOMMENT = "$notification.comment$"
+       HOSTDISPLAYNAME = "$host.display_name$"
+        SERVICEDISPLAYNAME = "$service.display_name$"
+        USEREMAIL = "$user.email$"
       }
     }
 
@@ -1032,7 +1032,7 @@ and `nrpe-disk` applied to the `nrpe-server`. The health check is defined as
 
     object Host "nrpe-server" {
       import "generic-host"
-      address = "192.168.1.5",
+      address = "192.168.1.5"
     }
 
     apply Dependency "disable-nrpe-checks" to Service {

diff --git a/doc/6-configuring-icinga-2.md b/doc/6-configuring-icinga-2.md
index aa446880b2831fa741784fdf5ff32921a09c4de4..57bee14b587b2257fbaf605de93fd77d855a30e8 100644 (file)
--- a/doc/6-configuring-icinga-2.md
+++ b/doc/6-configuring-icinga-2.md
@@ -251,7 +251,7 @@ Sets a dictionary element to the specified value.
 Example:
 
     {
-      a = 5,
+      a = 5
       a = 7
     }
 
@@ -875,18 +875,18 @@ Example:
       ]
 
       env = {
-        "NOTIFICATIONTYPE" = "$notification.type$"
-        "SERVICEDESC" = "$service.name$"
-        "HOSTALIAS" = "$host.display_name$",
-        "HOSTADDRESS" = "$address$",
-        "SERVICESTATE" = "$service.state$",
-        "LONGDATETIME" = "$icinga.long_date_time$",
-        "SERVICEOUTPUT" = "$service.output$",
-        "NOTIFICATIONAUTHORNAME" = "$notification.author$",
-        "NOTIFICATIONCOMMENT" = "$notification.comment$",
-        "HOSTDISPLAYNAME" = "$host.display_name$",
-        "SERVICEDISPLAYNAME" = "$service.display_name$",
-        "USEREMAIL" = "$user.email$"
+        NOTIFICATIONTYPE = "$notification.type$"
+        SERVICEDESC = "$service.name$"
+        HOSTALIAS = "$host.display_name$"
+        HOSTADDRESS = "$address$"
+        SERVICESTATE = "$service.state$"
+        LONGDATETIME = "$icinga.long_date_time$"
+        SERVICEOUTPUT = "$service.output$"
+        NOTIFICATIONAUTHORNAME = "$notification.author$"
+        NOTIFICATIONCOMMENT = "$notification.comment$"
+        HOSTDISPLAYNAME = "$host.display_name$"
+        SERVICEDISPLAYNAME = "$service.display_name$"
+        USEREMAIL = "$user.email$"
       }
     }
 

diff --git a/etc/icinga2/conf.d/commands.conf b/etc/icinga2/conf.d/commands.conf
index bcecd28a81b8b06189d07776ab84d66effe7e795..f39cfcd53dfe81f06ce90ed62c381b4871ac630e 100644 (file)
--- a/etc/icinga2/conf.d/commands.conf
+++ b/etc/icinga2/conf.d/commands.conf
@@ -6,16 +6,16 @@ object NotificationCommand "mail-host-notification" {
   command = [ SysconfDir + "/icinga2/scripts/mail-host-notification.sh" ]
 
   env = {
-    "NOTIFICATIONTYPE" = "$notification.type$"
-    "HOSTALIAS" = "$host.display_name$",
-    "HOSTADDRESS" = "$address$",
-    "HOSTSTATE" = "$host.state$",
-    "LONGDATETIME" = "$icinga.long_date_time$",
-    "HOSTOUTPUT" = "$host.output$",
-    "NOTIFICATIONAUTHORNAME" = "$notification.author$",
-    "NOTIFICATIONCOMMENT" = "$notification.comment$",
-    "HOSTDISPLAYNAME" = "$host.display_name$",
-    "USEREMAIL" = "$user.email$"
+    NOTIFICATIONTYPE = "$notification.type$"
+    HOSTALIAS = "$host.display_name$"
+    HOSTADDRESS = "$address$"
+    HOSTSTATE = "$host.state$"
+    LONGDATETIME = "$icinga.long_date_time$"
+    HOSTOUTPUT = "$host.output$"
+    NOTIFICATIONAUTHORNAME = "$notification.author$"
+    NOTIFICATIONCOMMENT = "$notification.comment$"
+    HOSTDISPLAYNAME = "$host.display_name$"
+    USEREMAIL = "$user.email$"
   }
 }
 
@@ -25,18 +25,18 @@ object NotificationCommand "mail-service-notification" {
   command = [ SysconfDir + "/icinga2/scripts/mail-service-notification.sh" ]
 
   env = {
-    "NOTIFICATIONTYPE" = "$notification.type$"
-    "SERVICEDESC" = "$service.name$"
-    "HOSTALIAS" = "$host.display_name$",
-    "HOSTADDRESS" = "$address$",
-    "SERVICESTATE" = "$service.state$",
-    "LONGDATETIME" = "$icinga.long_date_time$",
-    "SERVICEOUTPUT" = "$service.output$",
-    "NOTIFICATIONAUTHORNAME" = "$notification.author$",
-    "NOTIFICATIONCOMMENT" = "$notification.comment$",
-    "HOSTDISPLAYNAME" = "$host.display_name$",
-    "SERVICEDISPLAYNAME" = "$service.display_name$",
-    "USEREMAIL" = "$user.email$"
+    NOTIFICATIONTYPE = "$notification.type$"
+    SERVICEDESC = "$service.name$"
+    HOSTALIAS = "$host.display_name$"
+    HOSTADDRESS = "$address$"
+    SERVICESTATE = "$service.state$"
+    LONGDATETIME = "$icinga.long_date_time$"
+    SERVICEOUTPUT = "$service.output$"
+    NOTIFICATIONAUTHORNAME = "$notification.author$"
+    NOTIFICATIONCOMMENT = "$notification.comment$"
+    HOSTDISPLAYNAME = "$host.display_name$"
+    SERVICEDISPLAYNAME = "$service.display_name$"
+    USEREMAIL = "$user.email$"
   }
 }
 

diff --git a/etc/icinga2/features-available/debuglog.conf b/etc/icinga2/features-available/debuglog.conf
index 6789690762a9e319f4ab60c29bb5a3aec2bce1ba..6e8e5813e6112e0ac4318f842c213cb54c9eb1ef 100644 (file)
--- a/etc/icinga2/features-available/debuglog.conf
+++ b/etc/icinga2/features-available/debuglog.conf
@@ -5,7 +5,7 @@
  */
 
 object FileLogger "debug-file" {
-  severity = "debug",
+  severity = "debug"
   path = LocalStateDir + "/log/icinga2/debug.log"
 }
 

diff --git a/etc/icinga2/features-available/graphite.conf b/etc/icinga2/features-available/graphite.conf
index b855f9bb17c2b4e6142b3f09375b17b35be15d4f..f2e59d9e89fb73fbe9a78e4505c00fe6c21478c3 100644 (file)
--- a/etc/icinga2/features-available/graphite.conf
+++ b/etc/icinga2/features-available/graphite.conf
@@ -6,6 +6,6 @@
 library "perfdata"
 
 object GraphiteWriter "graphite" {
-  //host = "127.0.0.1",
+  //host = "127.0.0.1"
   //port = 2003
 }

diff --git a/etc/icinga2/features-available/ido-mysql.conf b/etc/icinga2/features-available/ido-mysql.conf
index b85322f29541fbce11818bcb69f955613fb69cb5..beab89f4cd10e294aba69423d6d29e77a86cc525 100644 (file)
--- a/etc/icinga2/features-available/ido-mysql.conf
+++ b/etc/icinga2/features-available/ido-mysql.conf
@@ -6,8 +6,8 @@
 library "db_ido_mysql"
 
 object IdoMysqlConnection "ido-mysql" {
-  //user = "icinga",
-  //password = "icinga",
-  //host = "localhost",
+  //user = "icinga"
+  //password = "icinga"
+  //host = "localhost"
   //database = "icinga"
 }

diff --git a/etc/icinga2/features-available/ido-pgsql.conf b/etc/icinga2/features-available/ido-pgsql.conf
index c8b8dfd57660d6647dc67ca14d8903cd9e57042b..2a20afa9a2dfe9fb5ff30c72966ac511e7bc46f7 100644 (file)
--- a/etc/icinga2/features-available/ido-pgsql.conf
+++ b/etc/icinga2/features-available/ido-pgsql.conf
@@ -6,8 +6,8 @@
 library "db_ido_pgsql"
 
 object IdoPgsqlConnection "ido-pgsql" {
-  //user = "icinga",
-  //password = "icinga",
-  //host = "localhost",
+  //user = "icinga"
+  //password = "icinga"
+  //host = "localhost"
   //database = "icinga"
 }

diff --git a/etc/icinga2/features-available/mainlog.conf b/etc/icinga2/features-available/mainlog.conf
index 773a0b43659ee72c421e3904587ae4f87d145158..ded9a7c7d96cda8d12c731908429c27ca2878120 100644 (file)
--- a/etc/icinga2/features-available/mainlog.conf
+++ b/etc/icinga2/features-available/mainlog.conf
@@ -3,7 +3,7 @@
  */
 
 object FileLogger "main-log" {
-  severity = "information",
+  severity = "information"
   path = LocalStateDir + "/log/icinga2/icinga2.log"
 }
 

diff --git a/itl/command-plugins.conf b/itl/command-plugins.conf
index 03243af67f6def0a42b31a89bfa3a8868e8e5d73..74dab6a0ae07ce4e2dcc2538ffe3595d46c74494 100644 (file)
--- a/itl/command-plugins.conf
+++ b/itl/command-plugins.conf
@@ -117,7 +117,7 @@ object CheckCommand "dummy" {
                PluginDir + "/check_dummy",
                "$dummy_state$",
                "$dummy_text$"
-       ],
+       ]
 
        vars.dummy_state = 0
        vars.dummy_text = "Check was successful."
@@ -492,9 +492,9 @@ object CheckCommand "dns" {
        command = PluginDir + "/check_dns"
 
        arguments = {
-               "-H" = "$dns_lookup$",
-               "-s" = "$dns_server$",
-               "-a" = "$dns_expected_answer$",
+               "-H" = "$dns_lookup$"
+               "-s" = "$dns_server$"
+               "-a" = "$dns_expected_answer$"
                "-A" = {
                        set_if = "$dns_authoritative$"
                }
@@ -510,8 +510,8 @@ object CheckCommand "dig" {
        command = PluginDir + "/check_dig"
 
        arguments = {
-               "-H" = "$dig_server$",
-               "-l" = "$dig_lookup$",
+               "-H" = "$dig_server$"
+               "-l" = "$dig_lookup$"
        }
 
        vars.dig_server = "$address$"