Checking if an unsigned long is < 0 is pointless.

Found by LLVM/clang 2.9.

diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 36ca67d3c145864cbcdbb1c94092b173e9074822..38f61577681cad1f43567aa3f75d023e61d789a6 100644 (file)
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -645,9 +645,9 @@ mmap_move_method(mmap_object *self, PyObject *args)
         return NULL;
     } else {
         /* bounds check the values */
-        if (cnt < 0 || (cnt + dest) < cnt || (cnt + src) < cnt ||
-           src < 0 || src > self->size || (src + cnt) > self->size ||
-           dest < 0 || dest > self->size || (dest + cnt) > self->size) {
+        if ((cnt + dest) < cnt || (cnt + src) < cnt ||
+           src > self->size || (src + cnt) > self->size ||
+           dest > self->size || (dest + cnt) > self->size) {
             PyErr_SetString(PyExc_ValueError,
                 "source, destination, or count out of range");
             return NULL;