Copy name when cloning FKs recurses to partitions

We were passing a string owned by a syscache entry, which was released
before recursing.  Fix by pstrdup'ing the string.

Per buildfarm member prion.

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 978b6bec44a19518ccd5d0dbef1dc45ccbe1244e..58eb7e1d8e83f0d8489045ba63f01e9190da6247 100644 (file)
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -8619,7 +8619,7 @@ CloneFkReferencing(List **wqueue, Relation parentRel, Relation partRel)
                                                                         "fkey",
                                                                         RelationGetNamespace(partRel), NIL);
                else
-                       fkconstraint->conname = NameStr(constrForm->conname);
+                       fkconstraint->conname = pstrdup(NameStr(constrForm->conname));
                fkconstraint->fk_upd_action = constrForm->confupdtype;
                fkconstraint->fk_del_action = constrForm->confdeltype;
                fkconstraint->deferrable = constrForm->condeferrable;