get_remote_group(): eliminate superfluous call to strcspn()

There is no need to call it if value is the empty string. This also
eliminates code duplication.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 680ba66e53cac367e1d6e623dbde86a5e92eb902..bbc2bb885966cad4fead45d266d8db2bff1332b3 100644 (file)
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -976,13 +976,13 @@ static int get_remote_group(const char *key, const char *value, void *priv)
        if (starts_with(key, "remotes.") &&
                        !strcmp(key + 8, g->name)) {
                /* split list by white space */
-               size_t wordlen = strcspn(value, " \t\n");
                while (*value) {
+                       size_t wordlen = strcspn(value, " \t\n");
+
                        if (wordlen >= 1)
                                string_list_append(g->list,
                                                   xstrndup(value, wordlen));
                        value += wordlen + (value[wordlen] != '\0');
-                       wordlen = strcspn(value, " \t\n");
                }
        }