]> granicus.if.org Git - icu/commitdiff
ICU-13634 Updating test expectations for the default currency long name.
authorShane Carr <shane@unicode.org>
Thu, 12 Apr 2018 04:04:23 +0000 (04:04 +0000)
committerShane Carr <shane@unicode.org>
Thu, 12 Apr 2018 04:04:23 +0000 (04:04 +0000)
X-SVN-Rev: 41218

icu4c/source/i18n/numparse_affixes.h
icu4c/source/test/intltest/numfmtst.cpp
icu4c/source/test/intltest/numfmtst.h
icu4j/main/classes/core/src/com/ibm/icu/impl/number/CustomSymbolCurrency.java
icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java

index 08a7d912c6a2ed2e1c65515d12a816c5e813f230..fe27cad03e91528688e3c684c6a188c91b8d74dc 100644 (file)
@@ -79,10 +79,6 @@ struct AffixTokenMatcherSetupData {
     const DecimalFormatSymbols& dfs;
     IgnorablesMatcher& ignorables;
     const Locale& locale;
-
-//    const UChar* currencyCode, const UnicodeString* currency1,
-//    const UnicodeString* currency2, const DecimalFormatSymbols* dfs,
-//            IgnorablesMatcher* ignorables, const Locale* locale
 };
 
 
index 9ac2f98d3dcfabad1f22fd20c3fe1f9f26f740a3..8afd143a390fd306e5e77e38371b792150e24c78 100644 (file)
@@ -651,6 +651,7 @@ void NumberFormatTest::runIndexedTest( int32_t index, UBool exec, const char* &n
   TESTCASE_AUTO(Test11649_toPatternWithMultiCurrency);
   TESTCASE_AUTO(Test13327_numberingSystemBufferOverflow);
   TESTCASE_AUTO(Test13391_chakmaParsing);
+  TESTCASE_AUTO(Test11735_ExceptionIssue);
   TESTCASE_AUTO(Test11035_FormatCurrencyAmount);
   TESTCASE_AUTO(Test11318_DoubleConversion);
   TESTCASE_AUTO_END;
@@ -8724,9 +8725,7 @@ void NumberFormatTest::Test11376_getAndSetPositivePrefix() {
         }
         DecimalFormat *dfmt = (DecimalFormat *) fmt.getAlias();
         UnicodeString result;
-        UnicodeString tripleIntlCurrency(" \\u00a4\\u00a4\\u00a4");
-        tripleIntlCurrency = tripleIntlCurrency.unescape();
-        assertEquals("", tripleIntlCurrency, dfmt->getPositiveSuffix(result));
+        assertEquals("", u" (unknown currency)", dfmt->getPositiveSuffix(result));
         dfmt->setCurrency(USD);
 
         // getPositiveSuffix() always returns the suffix for the
@@ -8919,8 +8918,8 @@ void NumberFormatTest::verifyFieldPositionIterator(
     }
 }
 
-void NumberFormatTest::checkExceptionIssue11735() {
-    UErrorCode status;
+void NumberFormatTest::Test11735_ExceptionIssue() {
+    UErrorCode status = U_ZERO_ERROR;
     Locale enLocale("en");
     DecimalFormatSymbols symbols(enLocale, status);
 
index c212bea393a6b725079ff5636ecfb01c957bcd34..d318cad93f9e1cee982e66fdd919f21e52fdb759 100644 (file)
@@ -218,7 +218,7 @@ class NumberFormatTest: public CalendarTimeZoneTest {
     void Test13327_numberingSystemBufferOverflow();
     void Test13391_chakmaParsing();
 
-    void checkExceptionIssue11735();
+    void Test11735_ExceptionIssue();
     void Test11035_FormatCurrencyAmount();
     void Test11318_DoubleConversion();
 
index b794aebe5344ba6af9241cbe57b148f51c72cf5d..a04170b6256a6dee6b2d3010bce3f7342a41c98d 100644 (file)
@@ -17,14 +17,14 @@ public class CustomSymbolCurrency extends Currency {
         if (currency == null) {
             currency = symbols.getCurrency();
         }
-        String currency1Sym = symbols.getCurrencySymbol();
-        String currency2Sym = symbols.getInternationalCurrencySymbol();
         if (currency == null) {
-            return new CustomSymbolCurrency("XXX", currency1Sym, currency2Sym);
+            return Currency.getInstance("XXX");
         }
         if (!currency.equals(symbols.getCurrency())) {
             return currency;
         }
+        String currency1Sym = symbols.getCurrencySymbol();
+        String currency2Sym = symbols.getInternationalCurrencySymbol();
         String currency1 = currency.getName(symbols.getULocale(), Currency.SYMBOL_NAME, null);
         String currency2 = currency.getCurrencyCode();
         if (!currency1.equals(currency1Sym) || !currency2.equals(currency2Sym)) {
index 728c538197b305d7144537b48eb3c243419b94a9..443dc1dbd5395b40c572e533a9f6c801cfc04e4d 100644 (file)
@@ -6032,7 +6032,9 @@ public class NumberFormatTest extends TestFmwk {
     public void testCurrencyPluralAffixOverrides() {
         // The affix setters should override CurrencyPluralInfo, used in the plural currency constructor.
         DecimalFormat df = (DecimalFormat) NumberFormat.getInstance(ULocale.ENGLISH, NumberFormat.PLURALCURRENCYSTYLE);
+        assertEquals("Defaults to unknown currency", " (unknown currency)", df.getPositiveSuffix());
         df.setCurrency(Currency.getInstance("USD"));
+        assertEquals("Should resolve to CurrencyPluralInfo", " US dollars", df.getPositiveSuffix());
         df.setPositiveSuffix("lala");
         assertEquals("Custom suffix should round-trip", "lala", df.getPositiveSuffix());
         assertEquals("Custom suffix should be used in formatting", "123.00lala", df.format(123));