]> granicus.if.org Git - postgresql/commitdiff
Remove ALTER DEFAULT PRIVILEGES' requirement of schema CREATE permissions.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 9 Jun 2013 19:26:48 +0000 (15:26 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 9 Jun 2013 19:26:48 +0000 (15:26 -0400)
Per discussion, this restriction isn't needed for any real security reason,
and it seems to confuse people more often than it helps them.  It could
also result in some database states being unrestorable.  So just drop it.

Back-patch to 9.0, where ALTER DEFAULT PRIVILEGES was introduced.

doc/src/sgml/ref/alter_default_privileges.sgml
src/backend/catalog/aclchk.c

index b5c8bb3a36bc989e101fb643109899681cd19055..fdd9c83800eaa2617c0dd61a6fce52e07d4b2bb0 100644 (file)
@@ -121,8 +121,8 @@ REVOKE [ GRANT OPTION FOR ]
     <term><replaceable>schema_name</replaceable></term>
     <listitem>
      <para>
-      The name of an existing schema.  Each <replaceable>target_role</>
-      must have <literal>CREATE</> privileges for each specified schema.
+      The name of an existing schema.  If specified, the default privileges
+      are altered for objects later created in that schema.
       If <literal>IN SCHEMA</> is omitted, the global default privileges
       are altered.
      </para>
index 296dfd314220c2b9e1acc4b3431dd4cb1e24dd2e..43134606d012c8d1e2462847d0f4302611ba1146 100644 (file)
@@ -1030,27 +1030,26 @@ SetDefaultACLsInSchemas(InternalDefaultACL *iacls, List *nspnames)
        }
        else
        {
-               /* Look up the schema OIDs and do permissions checks */
+               /* Look up the schema OIDs and set permissions for each one */
                ListCell   *nspcell;
 
                foreach(nspcell, nspnames)
                {
                        char       *nspname = strVal(lfirst(nspcell));
-                       AclResult       aclresult;
 
-                       /*
-                        * Note that we must do the permissions check against the target
-                        * role not the calling user.  We require CREATE privileges, since
-                        * without CREATE you won't be able to do anything using the
-                        * default privs anyway.
-                        */
                        iacls->nspid = get_namespace_oid(nspname, false);
 
-                       aclresult = pg_namespace_aclcheck(iacls->nspid, iacls->roleid,
-                                                                                         ACL_CREATE);
-                       if (aclresult != ACLCHECK_OK)
-                               aclcheck_error(aclresult, ACL_KIND_NAMESPACE,
-                                                          nspname);
+                       /*
+                        * We used to insist that the target role have CREATE privileges
+                        * on the schema, since without that it wouldn't be able to create
+                        * an object for which these default privileges would apply.
+                        * However, this check proved to be more confusing than helpful,
+                        * and it also caused certain database states to not be
+                        * dumpable/restorable, since revoking CREATE doesn't cause
+                        * default privileges for the schema to go away.  So now, we just
+                        * allow the ALTER; if the user lacks CREATE he'll find out when
+                        * he tries to create an object.
+                        */
 
                        SetDefaultACL(iacls);
                }