New XXX pointing out errors in the description of

PyArena_New(); unsure what the intent is.

diff --git a/Include/pyarena.h b/Include/pyarena.h
index 570fceab0e15363dd8080473bf2ea6f82ddf0267..16365563ad267b06ced48197bd4ef30b8f3e04b3 100644 (file)
--- a/Include/pyarena.h
+++ b/Include/pyarena.h
@@ -17,6 +17,12 @@ extern "C" {
 
      PyArena_New() returns an arena pointer.  On error, it
      returns a negative number and sets an exception.
+     XXX (tim):  Not true.  On error, PyArena_New() actually returns NULL,
+     XXX and looks like it may or may not set an exception (e.g., if the
+     XXX internal PyList_New(0) returns NULL, PyArena_New() passes that on
+     XXX and an exception is set; OTOH, if the internal
+     XXX block_new(DEFAULT_BLOCK_SIZE) returns NULL, that's passed on but
+     XXX an exception is not set in that case).
   */
   PyAPI_FUNC(PyArena *) PyArena_New(void);
   PyAPI_FUNC(void) PyArena_Free(PyArena *);