]> granicus.if.org Git - python/commitdiff
bpo-36150: Fix possible assertion failures due to _ctypes.c's PyCData_reduce(). ...
authorZackery Spytz <zspytz@gmail.com>
Sun, 31 Mar 2019 16:02:11 +0000 (10:02 -0600)
committerSerhiy Storchaka <storchaka@gmail.com>
Sun, 31 Mar 2019 16:02:11 +0000 (19:02 +0300)
Modules/_ctypes/_ctypes.c

index 03f8e756092c8c6ccc4081132c5837cbd6c68460..b3a20309472de64b96a172b8dd79c08097993641 100644 (file)
@@ -2743,10 +2743,11 @@ PyCData_reduce(PyObject *myself, PyObject *args)
                         "ctypes objects containing pointers cannot be pickled");
         return NULL;
     }
-    return Py_BuildValue("O(O(NN))",
-                         _unpickle,
-                         Py_TYPE(myself),
-                         PyObject_GetAttrString(myself, "__dict__"),
+    PyObject *dict = PyObject_GetAttrString(myself, "__dict__");
+    if (dict == NULL) {
+        return NULL;
+    }
+    return Py_BuildValue("O(O(NN))", _unpickle, Py_TYPE(myself), dict,
                          PyBytes_FromStringAndSize(self->b_ptr, self->b_size));
 }