]> granicus.if.org Git - php/commitdiff
Remove redundant htmlentities() tests
authorNikita Popov <nikita.ppv@gmail.com>
Thu, 7 May 2020 16:36:48 +0000 (18:36 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Thu, 7 May 2020 16:38:25 +0000 (18:38 +0200)
Test 04 and 15 are the same as 02 and 03, just for different
encodings. They don't add value, but their execution depends
on available locales, so they're easy to miss...

ext/standard/tests/strings/htmlentities04.phpt [deleted file]
ext/standard/tests/strings/htmlentities15.phpt [deleted file]

diff --git a/ext/standard/tests/strings/htmlentities04.phpt b/ext/standard/tests/strings/htmlentities04.phpt
deleted file mode 100644 (file)
index 7e47d8d..0000000
+++ /dev/null
@@ -1,21 +0,0 @@
---TEST--
-htmlentities() test 4 (setlocale / ja_JP.EUC-JP)
---SKIPIF--
-<?php
-$result = (bool)setlocale(LC_CTYPE, "ja_JP.EUC-JP", "ja_JP.eucJP");
-if (!$result || preg_match('/EUC[^a-zA-Z]*JP/i', setlocale(LC_CTYPE, 0)) == 0) {
-       die("skip setlocale() failed\n");
-}
-?>
---INI--
-output_handler=
-default_charset=
-internal_encoding=pass
---FILE--
-<?php
-    setlocale( LC_CTYPE, "ja_JP.EUC-JP", "ja_JP.eucJP" );
-    var_dump(htmlentities("\xa1\xa2\xa1\xa3\xa1\xa4", ENT_QUOTES, ''));
-?>
---EXPECTF--
-Notice: htmlentities(): Only basic entities substitution is supported for multi-byte encodings other than UTF-8; functionality is equivalent to htmlspecialchars in %s line %d
-string(6) "¡¢¡£¡¤"
diff --git a/ext/standard/tests/strings/htmlentities15.phpt b/ext/standard/tests/strings/htmlentities15.phpt
deleted file mode 100644 (file)
index 4144d62..0000000
+++ /dev/null
@@ -1,25 +0,0 @@
---TEST--
-htmlentities() test 15 (setlocale / KOI8-R)
---INI--
-output_handler=
-default_charset=
-internal_encoding=pass
---SKIPIF--
-<?php
-$result = (bool)setlocale(LC_CTYPE, "ru_RU.koi8r", "ru_RU.KOI8-R");
-if (!$result || preg_match('/koi8/i', setlocale(LC_CTYPE, 0)) == 0) {
-       die("skip setlocale() failed\n");
-}
-?>
---DESCRIPTION--
-As of PHP 5.4, htmlentities() no longer makes replacements with numerical
-entities. Hence, for this input there's no substitution.
---FILE--
-<?php
-setlocale(LC_CTYPE, "ru_RU.koi8r", "ru_RU.KOI8-R");
-$str = "ÒÏÓËÏÛÎÙÊ";
-var_dump($str, htmlentities($str, ENT_QUOTES, ''));
-?>
---EXPECT--
-string(9) "ÒÏÓËÏÛÎÙÊ"
-string(9) "ÒÏÓËÏÛÎÙÊ"