]> granicus.if.org Git - curl/commitdiff
base64: Minor coding standard and style updates
authorSteve Holme <steve_holme@hotmail.com>
Sun, 13 Mar 2016 17:59:06 +0000 (17:59 +0000)
committerSteve Holme <steve_holme@hotmail.com>
Sun, 13 Mar 2016 17:59:06 +0000 (17:59 +0000)
lib/base64.c

index 04cf2c9db00e47c1802d11f05e89fead9a280b3e..9bb7de4952b67fd0377fef44954d1af5b86cf030 100644 (file)
@@ -187,11 +187,11 @@ static CURLcode base64_encode(const char *table64,
   *outptr = NULL;
   *outlen = 0;
 
-  if(0 == insize)
+  if(!insize)
     insize = strlen(indata);
 
-  base64data = output = malloc(insize*4/3+4);
-  if(NULL == output)
+  base64data = output = malloc(insize * 4 / 3 + 4);
+  if(!output)
     return CURLE_OUT_OF_MEMORY;
 
   /*
@@ -233,12 +233,14 @@ static CURLcode base64_encode(const char *table64,
                table64[obuf[0]],
                table64[obuf[1]]);
       break;
+
     case 2: /* two bytes read */
       snprintf(output, 5, "%c%c%c=",
                table64[obuf[0]],
                table64[obuf[1]],
                table64[obuf[2]]);
       break;
+
     default:
       snprintf(output, 5, "%c%c%c%c",
                table64[obuf[0]],
@@ -249,12 +251,17 @@ static CURLcode base64_encode(const char *table64,
     }
     output += 4;
   }
+
+  /* Zero terminate */
   *output = '\0';
-  *outptr = base64data; /* return pointer to new data, allocated memory */
+
+  /* Return the pointer to the new data (allocated memory) */
+  *outptr = base64data;
 
   free(convbuf);
 
-  *outlen = strlen(base64data); /* return the length of the new data */
+  /* Return the length of the new data */
+  *outlen = strlen(base64data);
 
   return CURLE_OK;
 }
@@ -306,4 +313,3 @@ CURLcode Curl_base64url_encode(struct SessionHandle *data,
 {
   return base64_encode(base64url, data, inputbuff, insize, outptr, outlen);
 }
-/* ---- End of Base64 Encoding ---- */