]> granicus.if.org Git - clang/commitdiff
Make __atomic_init() (soon to be __c11_atomic_init()) work with non-scalar types.
authorDavid Chisnall <csdavec@swan.ac.uk>
Wed, 11 Apr 2012 17:24:05 +0000 (17:24 +0000)
committerDavid Chisnall <csdavec@swan.ac.uk>
Wed, 11 Apr 2012 17:24:05 +0000 (17:24 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@154507 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/atomicinit.cpp

index dbf41f38b8f8293f7b51194cbcc5f7e32566606a..260fa5b5291947fe12f811d64db3078650c5eaab 100644 (file)
@@ -2786,10 +2786,21 @@ RValue CodeGenFunction::EmitAtomicExpr(AtomicExpr *E, llvm::Value *Dest) {
 
   if (E->getOp() == AtomicExpr::Init) {
     assert(!Dest && "Init does not return a value");
-    Val1 = EmitScalarExpr(E->getVal1());
-    llvm::StoreInst *Store = Builder.CreateStore(Val1, Ptr);
-    Store->setAlignment(Size);
-    Store->setVolatile(E->isVolatile());
+    if (!hasAggregateLLVMType(E->getVal1()->getType())) {
+      llvm::StoreInst *Store =
+        Builder.CreateStore(EmitScalarExpr(E->getVal1()), Ptr);
+      Store->setAlignment(Size);
+      Store->setVolatile(E->isVolatile());
+    } else if (E->getType()->isAnyComplexType()) {
+      EmitComplexExprIntoAddr(E->getVal1(), Ptr, E->isVolatile());
+    } else {
+      AggValueSlot Slot = AggValueSlot::forAddr(Ptr, alignChars,
+                                        AtomicTy.getQualifiers(),
+                                        AggValueSlot::IsNotDestructed,
+                                        AggValueSlot::DoesNotNeedGCBarriers,
+                                        AggValueSlot::IsNotAliased);
+      EmitAggExpr(E->getVal1(), Slot);
+    }
     return RValue::get(0);
   }
 
index 17c5b62a3acf0ca2db7d71a363d313f6445b612b..63e38118fe15d9bfb447a12fd93502d7c68186b5 100644 (file)
@@ -10,3 +10,16 @@ void A::v(int j) { i = j; }
 // Initialising atomic values should not be atomic
 // CHECK-NOT: store atomic 
 A::A(int j) : i(j) {}
+
+struct B {
+  int i;
+  B(int x) : i(x) {}
+};
+
+_Atomic(B) b;
+
+// CHECK: define void @_Z11atomic_initR1Ai
+void atomic_init(A& a, int i) {
+  // CHECK-NOT: atomic
+  __atomic_init(&b, B(i));
+}