Issue 1340 by Amaury Forgeot d'Arc (with help from Christian Heimes,

and my own interpretation).
Don't pass the newline= flag to StringIO in SpooledTemporaryFile.
This avoids doubling newlines when the file is rolled over.

diff --git a/Lib/tempfile.py b/Lib/tempfile.py
index 3b21ff29353a840badb288f07ca1afd5ad5f4a35..d725a9d0b64606544e90f58e5dbb75f8a5d29203 100644 (file)
--- a/Lib/tempfile.py
+++ b/Lib/tempfile.py
@@ -495,7 +495,10 @@ class SpooledTemporaryFile:
         if 'b' in mode:
             self._file = _io.BytesIO()
         else:
-            self._file = _io.StringIO(encoding=encoding, newline=newline)
+            # Setting newline="\n" avoids newline translation;
+            # this is important because otherwise on Windows we'd
+            # hget double newline translation upon rollover().
+            self._file = _io.StringIO(encoding=encoding, newline="\n")
         self._max_size = max_size
         self._rolled = False
         self._TemporaryFileArgs = {'mode': mode, 'buffering': buffering,