]> granicus.if.org Git - python/commitdiff
Fix a bug introduced by the addition of the 'record' argument to
authorBrett Cannon <bcannon@gmail.com>
Thu, 8 May 2008 20:20:24 +0000 (20:20 +0000)
committerBrett Cannon <bcannon@gmail.com>
Thu, 8 May 2008 20:20:24 +0000 (20:20 +0000)
test.test_support.catch_warning() where showwarning() was not being set
properly.

Lib/test/test_support.py

index 25494a919ca0312dd6fd311c0bb8fa57c9ec79aa..9a45fdde8dca7809e0d6998d1851f73830837308 100644 (file)
@@ -406,11 +406,11 @@ def catch_warning(module=warnings, record=True):
             warnings.warn("foo")
             assert str(w.message) == "foo"
     """
+    original_filters = module.filters[:]
+    original_showwarning = module.showwarning
     if record:
         warning_obj = WarningMessage()
         module.showwarning = warning_obj._showwarning
-    original_filters = module.filters[:]
-    original_showwarning = module.showwarning
     try:
         yield warning_obj if record else None
     finally: