]> granicus.if.org Git - php/commitdiff
Fixing wring resource handle returned from mssql_query().
authorFrank M. Kromann <fmk@php.net>
Wed, 29 Nov 2000 17:08:22 +0000 (17:08 +0000)
committerFrank M. Kromann <fmk@php.net>
Wed, 29 Nov 2000 17:08:22 +0000 (17:08 +0000)
The error was introduced when adding mssql_fetch_batch().

ext/mssql/php_mssql.c

index 10bde67f04780b72a34e878e326acf83d83141a5..617a80a552dc6cbb9561e4efb9b9186920f72896 100644 (file)
@@ -899,12 +899,12 @@ PHP_FUNCTION(mssql_query)
                RETURN_FALSE;
        }
 
-       result = (mssql_result *) emalloc(sizeof(mssql_result));
        num_fields = dbnumcols(mssql_ptr->link);
        if (num_fields <= 0) {
-               RETURN_TRUE;
+               RETURN_FALSE;
        }
 
+       result = (mssql_result *) emalloc(sizeof(mssql_result));
        column_types = (int *) emalloc(sizeof(int) * num_fields);
        for (i=0; i<num_fields; i++) {
                column_types[i] = coltype(i+1);
@@ -961,7 +961,6 @@ PHP_FUNCTION(mssql_query)
        }
        efree(column_types);
        ZEND_REGISTER_RESOURCE(return_value, result, le_result);
-       RETURN_TRUE;
 }
 /* }}} */