Second round of review feedback.

* print out message when tests start
* testrunner sets status now
* on failed test run print out test name

I tested these changes with the non-parallel makefile
and it did not break.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@48453 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/Makefile.parallel b/test/Makefile.parallel
index 8162f816e7159de1f85e4b13607100214f85cbf1..5ab240ba8bc1615daf57aaf81ffa59d785321fd1 100644 (file)
--- a/test/Makefile.parallel
+++ b/test/Makefile.parallel
@@ -14,7 +14,7 @@ endif
 Makefile.tests:
        @ echo '%.testresults: %' > $@
        @ echo "^@ printf '.'" | tr "^" "\t" >> $@
-       @ echo "^@ PATH=$$PATH:$(ToolDir):$(LLVM_SRC_ROOT)/test/Scripts ./TestRunner.sh &< > &@ || echo $$^" | tr "^&" '\t$$' >> $@
+       @ echo "^@ PATH=$$PATH:$(ToolDir):$(LLVM_SRC_ROOT)/test/Scripts ./TestRunner.sh &< > &@ || (echo; echo '----' &! 'failed ----')" | tr '^!&' '\t^$$' >> $@
        @ echo >> $@
        @ echo "TESTS =" \\ >> $@
        @ find $(TESTDIRS) \
@@ -33,6 +33,7 @@ Makefile.tests:
        @ echo ".PHONY: all report clean" >> $@
 
 all:: Makefile.tests
+       @ echo '--- Running clang tests ---'
        @ $(MAKE) -f $< clean
        @ $(MAKE) -f $< all report
        @ $(MAKE) -f $< clean

diff --git a/test/TestRunner.sh b/test/TestRunner.sh
index cbbed75fa58501cfd2559f7831d7b02cf795a4c0..b649fab9cc9ebfaff25ab7399b66de121cbc4335 100755 (executable)
--- a/test/TestRunner.sh
+++ b/test/TestRunner.sh
@@ -52,5 +52,6 @@ grep -q XFAIL $FILENAME && (printf "XFAILED '$TESTNAME': "; grep XFAIL $FILENAME
   cat $OUTPUT
   rm $OUTPUT
   echo "******************** TEST '$TESTNAME' FAILED! ********************"
+  exit 1
 )