]> granicus.if.org Git - python/commitdiff
Merged revisions 84492 via svnmerge from
authorAntoine Pitrou <solipsis@pitrou.net>
Sat, 4 Sep 2010 17:33:06 +0000 (17:33 +0000)
committerAntoine Pitrou <solipsis@pitrou.net>
Sat, 4 Sep 2010 17:33:06 +0000 (17:33 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84492 | antoine.pitrou | 2010-09-04 19:32:06 +0200 (sam., 04 sept. 2010) | 4 lines

  Issue #9581: Fix non-working PosixGroupsTester test case
  (it only runs as root, which is why nobody bothered about the failure)
........

Lib/test/test_posix.py

index 42ad1af7d3bcf24b9b252afc46684c60df6031af..77f47fa1c25fcc8010ccaaaaff10a872cd7f1f02 100644 (file)
@@ -310,13 +310,7 @@ class PosixGroupsTester(unittest.TestCase):
     def test_initgroups(self):
         # find missing group
 
-        groups = sorted(self.saved_groups)
-        for g1,g2 in zip(groups[:-1], groups[1:]):
-            g = g1 + 1
-            if g < g2:
-                break
-        else:
-            g = g2 + 1
+        g = max(self.saved_groups) + 1
         name = pwd.getpwuid(posix.getuid()).pw_name
         posix.initgroups(name, g)
         self.assertIn(g, posix.getgroups())
@@ -324,7 +318,7 @@ class PosixGroupsTester(unittest.TestCase):
     @unittest.skipUnless(hasattr(posix, 'setgroups'),
                          "test needs posix.setgroups()")
     def test_setgroups(self):
-        for groups in [[0], range(16)]:
+        for groups in [[0], list(range(16))]:
             posix.setgroups(groups)
             self.assertListEqual(groups, posix.getgroups())