I am sorry I tried fixing PHP without extensive discussion on the mailing list.

I am sorry I tried fixing PHP without extensive discussion on the mailing list.
I am sorry I tried fixing PHP without extensive discussion on the mailing list.

Hope all the relevant parties are satisfied.

diff --git a/configure.in b/configure.in
index 1f0622b1bbca6856f4df58c6e71cbd982c4d83f4..e48cadfa66b4c650ca9775326616fb3aaa7d61fd 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -896,12 +896,6 @@ else
   AC_MSG_RESULT([using system default])
 fi
 
-PHP_ARG_ENABLE(large-uploads-fix, whether to enable large files (2G-4G) uploads fix,
-[  --enable-large-uploads-fix Enable large files (2G-4G) uploads fix], no, no)
-if test "$PHP_LARGE_UPLOADS_FIX" = "yes"; then
-       AC_DEFINE(HAVE_LARGE_UPLOADS_FIX, 1, [Whether to enable large files (2G-4G) uploads fix])
-fi
-
 divert(5)
 
 dnl ## In diversion 5 we check which extensions should be compiled.

diff --git a/ext/standard/file.c b/ext/standard/file.c
index e877d4f21b56c1737657e02e336e2b3087d59701..6fd1a4d9602ed436b0d12a6d920a1386df170d4d 100644 (file)
--- a/ext/standard/file.c
+++ b/ext/standard/file.c
@@ -579,8 +579,7 @@ PHP_FUNCTION(file_put_contents)
        char *filename;
        int filename_len;
        zval *data;
-       size_t numbytes = 0;
-       int result = SUCCESS;
+       int numbytes = 0;
        long flags = 0;
        zval *zcontext = NULL;
        php_stream_context *context = NULL;
@@ -623,7 +622,7 @@ PHP_FUNCTION(file_put_contents)
                case IS_RESOURCE: {
                        size_t len;
                        if (php_stream_copy_to_stream_ex(srcstream, stream, PHP_STREAM_COPY_ALL, &len) != SUCCESS) {
-                               result = FAILURE;
+                               numbytes = -1;
                        } else {
                                numbytes = len;
                        }
@@ -641,7 +640,7 @@ PHP_FUNCTION(file_put_contents)
                                numbytes = php_stream_write(stream, Z_STRVAL_P(data), Z_STRLEN_P(data));
                                if (numbytes != Z_STRLEN_P(data)) {
                                        php_error_docref(NULL TSRMLS_CC, E_WARNING, "Only %d of %d bytes written, possibly out of free disk space", numbytes, Z_STRLEN_P(data));
-                                       result = FAILURE;
+                                       numbytes = -1;
                                }
                        }
                        break;
@@ -667,7 +666,7 @@ PHP_FUNCTION(file_put_contents)
                                                        } else {
                                                                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Only %d of %d bytes written, possibly out of free disk space",  bytes_written, Z_STRLEN_PP(tmp));
                                                        }
-                                                       result = FAILURE;
+                                                       numbytes = -1;
                                                        break;
                                                }
                                        }
@@ -684,19 +683,19 @@ PHP_FUNCTION(file_put_contents)
                                        numbytes = php_stream_write(stream, Z_STRVAL(out), Z_STRLEN(out));
                                        if (numbytes != Z_STRLEN(out)) {
                                                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Only %d of %d bytes written, possibly out of free disk space", numbytes, Z_STRLEN(out));
-                                               result = FAILURE;
+                                               numbytes = -1;
                                        }
                                        zval_dtor(&out);
                                        break;
                                }
                        }
                default:
-                       result = FAILURE;
+                       numbytes = -1;          
                        break;
        }
        php_stream_close(stream);
 
-       if (result == FAILURE) {
+       if (numbytes < 0) {
                RETURN_FALSE;   
        }
 

diff --git a/main/SAPI.c b/main/SAPI.c
index f1c540b71065e7eb25d8f96c7cdb2fbb31e5a9f5..443101dec3188b890be2260aabdf3582ec3929d3 100644 (file)
--- a/main/SAPI.c
+++ b/main/SAPI.c
@@ -191,8 +191,8 @@ static void sapi_read_post_data(TSRMLS_D)
 
 SAPI_API SAPI_POST_READER_FUNC(sapi_read_standard_form_data)
 {
-       size_t read_bytes;
-       size_t allocated_bytes=SAPI_POST_BLOCK_SIZE+1;
+       int read_bytes;
+       int allocated_bytes=SAPI_POST_BLOCK_SIZE+1;
 
        if (SG(request_info).content_length > SG(post_max_size)) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "POST Content-Length of %ld bytes exceeds the limit of %ld bytes",

diff --git a/main/SAPI.h b/main/SAPI.h
index 2f5db36eff712fdbb690dd55dcffbf26c39e0136..b19195b3ada794ef1592fc792395d56dbbf49b05 100644 (file)
--- a/main/SAPI.h
+++ b/main/SAPI.h
@@ -118,11 +118,7 @@ typedef struct _sapi_globals_struct {
        void *server_context;
        sapi_request_info request_info;
        sapi_headers_struct sapi_headers;
-#ifdef HAVE_LARGE_UPLOADS_FIX
-       size_t read_post_bytes;
-#else
        int read_post_bytes;
-#endif
        unsigned char headers_sent;
        struct stat global_stat;
        char *default_mimetype;

diff --git a/main/rfc1867.c b/main/rfc1867.c
index ecb87545c6346dfa3648bec7d0410a908a531de5..da4f3c6fda4c9ef23509e84f35d00e55bf73cd51 100644 (file)
--- a/main/rfc1867.c
+++ b/main/rfc1867.c
@@ -765,9 +765,8 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler) /* {{{ */
 {
        char *boundary, *s = NULL, *boundary_end = NULL, *start_arr = NULL, *array_index = NULL;
        char *temp_filename = NULL, *lbuf = NULL, *abuf = NULL;
-       int boundary_len = 0, cancel_upload = 0, is_arr_upload = 0, array_len = 0;
-       int skip_upload = 0, anonindex = 0, is_anonymous;
-       size_t total_bytes = 0, max_file_size = 0;
+       int boundary_len = 0, total_bytes = 0, cancel_upload = 0, is_arr_upload = 0, array_len = 0;
+       int max_file_size = 0, skip_upload = 0, anonindex = 0, is_anonymous;
        zval *http_post_files = NULL;
        HashTable *uploaded_files = NULL;
 #if HAVE_MBSTRING && !defined(COMPILE_DL_MBSTRING)