imap-send: properly error out if imap.host is not set in config

If no imap host is specified in the git config, git imap-send used
to try to lookup a null pointer through gethostbyname(), causing a
segfault.  Since setting the imap.host variable is mandatory,
imap-send now properly fails with an explanatory error message.

The problem has been reported by picca through
 http://bugs.debian.org/472632

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/imap-send.c b/imap-send.c
index 10cce15a427646a1281afa5197f40def39151154..04afbc492485d95a85a7f0f57bbb48def6337a99 100644 (file)
--- a/imap-send.c
+++ b/imap-send.c
@@ -1302,6 +1302,10 @@ main(int argc, char **argv)
                fprintf( stderr, "no imap store specified\n" );
                return 1;
        }
+       if (!server.host) {
+               fprintf( stderr, "no imap host specified\n" );
+               return 1;
+       }
 
        /* read the messages */
        if (!read_message( stdin, &all_msgs )) {