Add Valgrind suppression for reorderbuffer padding bytes.

Andres Freund

diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp
index d3447d7feb8fde23017024cfe0577f4191495199..268957cdca446d2105b398ee66a8ac0edaedd423 100644 (file)
--- a/src/tools/valgrind.supp
+++ b/src/tools/valgrind.supp
@@ -5,6 +5,9 @@
 # The libc symbol that implements a particular standard interface is
 # implementation-dependent.  For example, strncpy() shows up as "__GI_strncpy"
 # on some platforms.  Use wildcards to avoid mentioning such specific names.
+# Avoid mentioning functions that are good candidates for inlining,
+# particularly single-caller static functions.  Suppressions mentioning them
+# would be ineffective at higher optimization levels.
 
 
 # We have occasion to write raw binary structures to disk or to the network.
@@ -63,6 +66,15 @@
        fun:write_relcache_init_file
 }
 
+{
+       padding_reorderbuffer_serialize
+       Memcheck:Param
+       write(buf)
+
+       ...
+       fun:ReorderBufferSerializeTXN
+}
+
 
 # gcc on ppc64 can generate a four-byte read to fetch the final "char" fields
 # of a FormData_pg_cast.  This is valid compiler behavior, because a proper