Fix the ST_MakeValid leak, keep it crash-free (#2307)

git-svn-id: http://svn.osgeo.org/postgis/trunk@11636 b70326c6-7e19-0410-871a-916f4a2858ee

diff --git a/liblwgeom/lwgeom_geos_clean.c b/liblwgeom/lwgeom_geos_clean.c
index 52a0c7e94278f96aeb8b792b17fa1f3b5cc5e826..53dea0740ba81361c29ce0673b360d83b5dc299d 100644 (file)
--- a/liblwgeom/lwgeom_geos_clean.c
+++ b/liblwgeom/lwgeom_geos_clean.c
@@ -1053,8 +1053,7 @@ lwgeom_make_valid(LWGEOM* lwgeom_in)
        {
                LWDEBUG(3, "lwgeom_make_valid: forcing multi");
                lwgeom_tmp = lwgeom_as_multi(lwgeom_out);
-               /* Don't free lwgeom_out, or you'll free memory underneath lwgeom_tmp */
-               /* lwgeom_free(lwgeom_out); */
+               lwfree(lwgeom_out); /* note: only frees the wrapper, not the content */
                lwgeom_out = lwgeom_tmp;
        }