Add UPGRADING notes

[ci skip]

diff --git a/NEWS b/NEWS
index f7cbf70f7434681cf92e893e30dd3fbcb418b727..d3962127c78881871cfa3f1d5f75ae0781f155e5 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,9 @@ PHP                                                                        NEWS
   . Fixed bug #76480 (Use curl_multi_wait() so that timeouts are respected).
     (Pierrick)
 
+- Date:
+  . Fixed bug #75232 (print_r of DateTime creating side-effect). (Nikita)
+
 - Hash:
   . The hash extension is now an integral part of PHP and cannot be disabled
     as per RFC: https://wiki.php.net/rfc/permanent_hash_ext. (Kalle)

diff --git a/UPGRADING b/UPGRADING
index ff72fa0beb8c218ccaae96e100020ef1bd3901e0..cdec63d5f4b95dbb1ecfc27f0a459266e34d7038 100644 (file)
--- a/UPGRADING
+++ b/UPGRADING
@@ -19,6 +19,10 @@ PHP 7.4 UPGRADE NOTES
 1. Backward Incompatible Changes
 ========================================
 
+- Date:
+  . Calling var_dump() or similar on a DateTime(Immutable) instance will no
+    longer leave behind accessible properties on the object.
+
 - Intl:
   . The default parameter value of idn_to_ascii() and idn_to_utf8() is now
     INTL_IDNA_VARIANT_UTS46 instead of the deprecated INTL_IDNA_VARIANT_2003.
@@ -29,6 +33,21 @@ PHP 7.4 UPGRADE NOTES
     supported and resulted in corrupted reflection objects. It has been
     explicitly prohibited now.
 
+- SPL:
+  . Calling get_object_vars() on an ArrayObject instance will now always return
+    the properties of the ArrayObject itself (or a subclass). Previously it
+    returned the values of the wrapped array/object unless the STD_PROP_LIST
+    flag was specified. Other affected operations are:
+
+     * ReflectionObject::getProperties()
+     * array_key_exists(). Use isset() or offsetExists() instead.
+     * reset(), current(), etc. Use Iterator methods instead.
+     * Potentially others working on object properties as a list.
+
+    (array) casts are *not* affected. They will continue to return either the
+    wrapped array, or the ArrayObject properties, depending on whether the
+    STD_PROP_LIST flag is used.
+
 ========================================
 2. New Features
 ========================================

diff --git a/UPGRADING.INTERNALS b/UPGRADING.INTERNALS
index 2d2df715d1b835e73e92e2afc6262afe1032e4fe..0fadae38189df87c2cb6fe6a203c5dc7cfe2984a 100644 (file)
--- a/UPGRADING.INTERNALS
+++ b/UPGRADING.INTERNALS
@@ -5,6 +5,8 @@ PHP 7.4 INTERNALS UPGRADE NOTES
   b. zend_lookup_class_ex() and zend_fetch_class_by_name()
   c. Function/property/class flags
   d. Removed zend_check_private()
+  e. php_win32_error_to_msg() memory management
+  f. get_properties_for() handler / Z_OBJDEBUG_P
 
 2. Build system changes
   a. Abstract
@@ -50,6 +52,52 @@ PHP 7.4 INTERNALS UPGRADE NOTES
      php_win32_error_msg_free(). Same regarding php_win_err() vs.
      php_win_err_free().
 
+  f. A new, optional object handler with the signature
+
+         HashTable *get_properties_for(zval *obj, zend_prop_purpose purpose)
+
+     has been introduced, where zend_prop_purpose (currently) takes one of:
+
+         ZEND_PROP_PURPOSE_DEBUG       // var_dump etc.
+         ZEND_PROP_PURPOSE_ARRAY_CAST  // (array) $obj
+         ZEND_PROP_PURPOSE_SERIALIZE   // "O"-format serialization (__wakeup)
+         ZEND_PROP_PURPOSE_VAR_EXPORT  // var_export (__set_state)
+         ZEND_PROP_PURPOSE_JSON        // json_encode
+
+     The handler returns a non-null HashTable with increased refcounted, and
+     the return value must be released using zend_release_properties().
+     
+     This handler serves the same general function as get_properties(), but
+     provides more control over different property uses, while also making
+     it possible to return a temporary property table.
+     
+     get_properties() is still used in cases where none of the above purposes
+     apply, but overloading get_properties() is generally discouraged. If you
+     want to provide purposes for general usage rather than just debugging or
+     serialization, please prefer using properly declared properties.
+
+     get_debug_info() is superseded by get_properties_for() with the
+     ZEND_PROP_PURPOSE_DEBUG purpose, but remains available for backwards-
+     compatibility reasons. However, while it is fine to define this handler,
+     it should never be directly called by consuming code.
+
+     The Z_OBJDEBUG_P macro has been removed. It should be replaced by calls to
+     zend_get_properties_for() with the ZEND_PROP_PURPOSE_DEBUG purpose:
+
+         // OLD
+         int is_temp;
+         HashTable *ht = Z_OBJDEBUG_P(obj, is_temp);
+         // ...
+         if (is_temp) {
+            zend_hash_destroy(ht);
+            FREE_HASHTABLE(ht);
+         }
+
+         // NEW
+         HashTable *ht = zend_get_properties_for(obj, ZEND_PROP_PURPOSE_DEBUG);
+         // ...
+         zend_release_properties(ht);
+
 ========================
 2. Build system changes
 ========================