A couple of observations

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97199 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/modules/arch/netware/mod_nw_ssl.c b/modules/arch/netware/mod_nw_ssl.c
index bbb0b5678e57d8fb886ade23b44de001f386b72e..c474812f566c2840d9003cae9aca75306c0f1c5a 100644 (file)
--- a/modules/arch/netware/mod_nw_ssl.c
+++ b/modules/arch/netware/mod_nw_ssl.c
@@ -147,6 +147,9 @@ static unsigned long parse_addr(const char *w, unsigned short *ports)
     hep = gethostbyname(w);
 
     if ((!hep) || (hep->h_addrtype != AF_INET || !hep->h_addr_list[0])) {
+        /* XXX Should be echoing by r_errno the actual failure, no? 
+         * ap_log_error would be good here.
+         */
         fprintf(stderr, "Cannot resolve host name %s --- exiting!\n", w);
         exit(1);
     }

diff --git a/server/util.c b/server/util.c
index f0aabab11251987a897176be4b084b450421358d..166dec82aba0217252fcc4f97b7de362c23aebe5 100644 (file)
--- a/server/util.c
+++ b/server/util.c
@@ -1837,6 +1837,7 @@ char *ap_get_local_host(apr_pool_t *a)
     else 
     {
         str[sizeof(str) - 1] = '\0';
+        /* TODO: Screaming for APR-ization */
         if ((!(p = gethostbyname(str))) 
             || (!(server_hostname = find_fqdn(a, p)))) {
             /* Recovery - return the default servername by IP: */