]> granicus.if.org Git - php/commitdiff
Remove unnecessary base64_encode() return value check
authorbugreportuser <37939393+bugreportuser@users.noreply.github.com>
Sat, 22 Sep 2018 15:02:23 +0000 (11:02 -0400)
committerNikita Popov <nikita.ppv@gmail.com>
Sun, 23 Sep 2018 12:49:10 +0000 (14:49 +0200)
php_base64_encode() never returns NULL, so base64_encode() will never return
false.

ext/standard/base64.c

index fb6d491acfec0b6c2944fb8f6382ec3d04f471d1..c750c7a0b939cf56fa655d05c45bd98daea144b6 100644 (file)
@@ -790,11 +790,7 @@ PHP_FUNCTION(base64_encode)
        ZEND_PARSE_PARAMETERS_END();
 
        result = php_base64_encode((unsigned char*)str, str_len);
-       if (result != NULL) {
-               RETURN_STR(result);
-       } else {
-               RETURN_FALSE;
-       }
+       RETURN_STR(result);
 }
 /* }}} */