]> granicus.if.org Git - python/commitdiff
bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318)
authorLysandros Nikolaou <lisandrosnik@gmail.com>
Sun, 4 Nov 2018 21:21:28 +0000 (22:21 +0100)
committerNed Deily <nad@python.org>
Sun, 4 Nov 2018 21:21:28 +0000 (16:21 -0500)
Lib/test/test_gdb.py
Misc/ACKS
Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst [new file with mode: 0644]

index 0f950b23253391af67263a7d78b76e22352d11e8..711fb69ebdffcac0c0451d82cdb2ba0f9dac5aa6 100644 (file)
@@ -5,6 +5,7 @@
 
 import locale
 import os
+import platform
 import re
 import subprocess
 import sys
@@ -48,6 +49,10 @@ if gdb_major_version < 7:
 if not sysconfig.is_python_build():
     raise unittest.SkipTest("test_gdb only works on source builds at the moment.")
 
+if 'Clang' in platform.python_compiler() and sys.platform == 'darwin':
+    raise unittest.SkipTest("test_gdb doesn't work correctly when python is"
+                            " built with LLVM clang")
+
 # Location of custom hooks file in a repository checkout.
 checkout_hook_path = os.path.join(os.path.dirname(sys.executable),
                                   'python-gdb.py')
index 08ff6d11fdd0f344dff96482b04eb46ce06a5562..89fb0c7000b45ecdaf9e8136a6616327dde8d8d1 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1147,6 +1147,7 @@ Samuel Nicolary
 Jonathan Niehof
 Gustavo Niemeyer
 Oscar Nierstrasz
+Lysandros Nikolaou
 Hrvoje Nikšić
 Gregory Nofi
 Jesse Noller
diff --git a/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst
new file mode 100644 (file)
index 0000000..9c6b4ef
--- /dev/null
@@ -0,0 +1,4 @@
+After several reports that test_gdb does not work properly on macOS and
+since gdb is not shipped by default anymore, test_gdb is now skipped on
+macOS when LLVM Clang has been used to compile Python. Patch by
+Lysandros Nikolaou