// Complex Expression Emitter
//===----------------------------------------------------------------------===//
-typedef std::pair<llvm::Value *, llvm::Value *> ComplexPairTy;
+typedef CodeGenFunction::ComplexPairTy ComplexPairTy;
namespace {
class VISIBILITY_HIDDEN ComplexExprEmitter
ComplexPairTy VisitBinaryOperator(const BinaryOperator *BO);
ComplexPairTy VisitBinMul (const BinaryOperator *E);
ComplexPairTy VisitBinAdd (const BinaryOperator *E);
+
+ // No comparisons produce a complex result.
ComplexPairTy VisitBinAssign (const BinaryOperator *E);
/// EmitComplexExpr - Emit the computation of the specified expression of
/// complex type, ignoring the result.
-void CodeGenFunction::EmitComplexExpr(const Expr *E) {
+ComplexPairTy CodeGenFunction::EmitComplexExpr(const Expr *E) {
assert(E && E->getType()->isComplexType() &&
"Invalid complex expression to emit");
- ComplexExprEmitter(*this).Visit(const_cast<Expr*>(E));
+ return ComplexExprEmitter(*this).Visit(const_cast<Expr*>(E));
}
RValue CodeGenFunction::EmitBinaryCompare(const BinaryOperator *E,
unsigned UICmpOpc, unsigned SICmpOpc,
unsigned FCmpOpc) {
- RValue LHS = EmitExpr(E->getLHS());
- RValue RHS = EmitExpr(E->getRHS());
-
llvm::Value *Result;
- if (LHS.isScalar()) {
- if (LHS.getVal()->getType()->isFloatingPoint()) {
+ QualType LHSTy = E->getLHS()->getType();
+ if (!LHSTy->isComplexType()) {
+ RValue LHS = EmitExpr(E->getLHS());
+ RValue RHS = EmitExpr(E->getRHS());
+
+ if (LHSTy->isRealFloatingType()) {
Result = Builder.CreateFCmp((llvm::FCmpInst::Predicate)FCmpOpc,
LHS.getVal(), RHS.getVal(), "cmp");
- } else if (E->getLHS()->getType()->isUnsignedIntegerType()) {
+ } else if (LHSTy->isUnsignedIntegerType()) {
// FIXME: This check isn't right for "unsigned short < int" where ushort
// promotes to int and does a signed compare.
Result = Builder.CreateICmp((llvm::ICmpInst::Predicate)UICmpOpc,
LHS.getVal(), RHS.getVal(), "cmp");
}
} else {
-#if 0
- // Struct/union/complex
- llvm::Value *LHSR, *LHSI, *RHSR, *RHSI, *ResultR, *ResultI;
- EmitLoadOfComplex(LHS, LHSR, LHSI);
- EmitLoadOfComplex(RHS, RHSR, RHSI);
-
- // FIXME: need to consider _Complex over integers too!
-
- ResultR = Builder.CreateFCmp((llvm::FCmpInst::Predicate)FCmpOpc,
- LHSR, RHSR, "cmp.r");
- ResultI = Builder.CreateFCmp((llvm::FCmpInst::Predicate)FCmpOpc,
- LHSI, RHSI, "cmp.i");
- if (BinaryOperator::EQ == E->getOpcode()) {
+ // Complex Comparison: can only be an equality comparison.
+ ComplexPairTy LHS = EmitComplexExpr(E->getLHS());
+ ComplexPairTy RHS = EmitComplexExpr(E->getRHS());
+
+ QualType CETy =
+ cast<ComplexType>(LHSTy.getCanonicalType())->getElementType();
+
+ llvm::Value *ResultR, *ResultI;
+ if (CETy->isRealFloatingType()) {
+ ResultR = Builder.CreateFCmp((llvm::FCmpInst::Predicate)FCmpOpc,
+ LHS.first, RHS.first, "cmp.r");
+ ResultI = Builder.CreateFCmp((llvm::FCmpInst::Predicate)FCmpOpc,
+ LHS.second, RHS.second, "cmp.i");
+ } else {
+ unsigned Opc = CETy->isUnsignedIntegerType() ? UICmpOpc : SICmpOpc;
+ ResultR = Builder.CreateICmp((llvm::ICmpInst::Predicate)Opc,
+ LHS.first, RHS.first, "cmp.r");
+ ResultI = Builder.CreateICmp((llvm::ICmpInst::Predicate)Opc,
+ LHS.second, RHS.second, "cmp.i");
+ }
+
+ if (E->getOpcode() == BinaryOperator::EQ) {
Result = Builder.CreateAnd(ResultR, ResultI, "and.ri");
- } else if (BinaryOperator::NE == E->getOpcode()) {
- Result = Builder.CreateOr(ResultR, ResultI, "or.ri");
} else {
- assert(0 && "Complex comparison other than == or != ?");
+ assert(E->getOpcode() == BinaryOperator::NE &&
+ "Complex comparison other than == or != ?");
+ Result = Builder.CreateOr(ResultR, ResultI, "or.ri");
}
-#endif
}
// ZExt result to int.