kill: Fix free() with bad pointer on SIG-prefixed signal-name

kill -l SIGHUP (or any other signal-name prefixed with "SIG")
would cause free() to be called with a bad pointer instead of
a pointer to what was allocated. Fix this and add test-case.

diff --git a/proc/sig.c b/proc/sig.c
index 2191cda53c40e28e6f6ca3ff8c345fcbd3b3b588..a93aabb912342b2f4d2167f2379f9956a9409b9c 100644 (file)
--- a/proc/sig.c
+++ b/proc/sig.c
@@ -261,7 +261,7 @@ char *strtosig(const char *restrict s){
       }
     }
   }
-  free(p);
+  free(copy);
   return converted;
 }
 

diff --git a/testsuite/kill.test/kill.exp b/testsuite/kill.test/kill.exp
index 1668ac4f3676f8b8e2f91c7803adeeb9c2df5776..211395c95077d971ad31ee60d2806908c0febd39 100644 (file)
--- a/testsuite/kill.test/kill.exp
+++ b/testsuite/kill.test/kill.exp
@@ -24,6 +24,10 @@ set test "kill convert signal name to number"
 spawn  $kill -lHUP
 expect_pass "$test" "^1\\s*"
 
+set test "kill convert SIG-prefixed signal name to number"
+spawn  $kill -lSIGHUP
+expect_pass "$test" "^1\\s*$"
+
 set test "kill convert signal number to name"
 spawn  $kill -l 1
 expect_pass "$test" "^HUP\\s*"