patch 8.2.4016: Vim9: incorrect error for argument that is shadowing var

Problem:    Vim9: incorrect error for argument that is shadowing var.
Solution:   Ignore variable that is not in block where the function was
            defined.

diff --git a/src/testdir/test_vim9_func.vim b/src/testdir/test_vim9_func.vim
index 025edd5dafa332152a854b45c2a597b8484d155f..9e420ade748b9794fcdeb08fc305743ce67b53ef 100644 (file)
--- a/src/testdir/test_vim9_func.vim
+++ b/src/testdir/test_vim9_func.vim
@@ -933,6 +933,21 @@ def Test_local_function_shadows_global()
       delfunc g:Func
   END
   CheckScriptSuccess(lines)
+
+  # This does not shadow "i" which is visible only inside the for loop
+  lines =<< trim END
+      vim9script
+
+      def Foo(i: number)
+        echo i
+      enddef
+
+      for i in range(3)
+        # Foo() is compiled here
+        Foo(i)
+      endfor
+  END
+  CheckScriptSuccess(lines)
 enddef
 
 func TakesOneArg(arg)

diff --git a/src/version.c b/src/version.c
index d331c87085e772be4dc73eaa1f9871e35b478a42..dafef8ec9867d35a8e5a56d7d011dc463aa2708c 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    4016,
 /**/
     4015,
 /**/

diff --git a/src/vim9compile.c b/src/vim9compile.c
index da93c1b893b3a7ae146c78bd340ade37f0ea9a45..453e3f545256a5c6869e08a97e057bd4084ed307 100644 (file)
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -162,7 +162,6 @@ find_script_var(char_u *name, size_t len, cctx_T *cctx)
     hashitem_T     *hi;
     int                    cc;
     sallvar_T      *sav;
-    sallvar_T      *found_sav;
     ufunc_T        *ufunc;
 
     // Find the list of all script variables with the right name.
@@ -198,7 +197,6 @@ find_script_var(char_u *name, size_t len, cctx_T *cctx)
     // Go over the variables with this name and find one that was visible
     // from the function.
     ufunc = cctx->ctx_ufunc;
-    found_sav = sav;
     while (sav != NULL)
     {
        int idx;
@@ -211,8 +209,8 @@ find_script_var(char_u *name, size_t len, cctx_T *cctx)
        sav = sav->sav_next;
     }
 
-    // Not found, assume variable at script level was visible.
-    return found_sav;
+    // Not found, variable was not visible.
+    return NULL;
 }
 
 /*