Remove inadequate check for duplicate "xml" PI.

I failed to think about PIs starting with "xml".  We don't really
need this check at all, so just take it out.  Oversight in
commit 8d1dadb25 et al.

diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index f8f271c6269a605610105b5c2c4c0758ff58125c..3a857bb026006b310c1d3802cd1836388bf46db3 100644 (file)
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -1458,10 +1458,6 @@ xml_doctype_in_content(const xmlChar *str)
                if (!e)
                        return false;
 
-               /* we don't check PIs carefully, but do reject "xml" target */
-               if (e - p >= 3 && xmlStrncasecmp(p, (xmlChar *) "xml", 3) == 0)
-                       return false;
-
                /* advance over PI, keep scanning */
                p = e + 2;
        }