]> granicus.if.org Git - cgit/commitdiff
Mark char* fields in struct cgit_page as const
authorJohn Keeping <john@keeping.me.uk>
Sun, 7 Apr 2013 11:46:45 +0000 (12:46 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Mon, 8 Apr 2013 13:59:51 +0000 (15:59 +0200)
Signed-off-by: John Keeping <john@keeping.me.uk>
cgit.h
ui-plain.c

diff --git a/cgit.h b/cgit.h
index fc3fc6fb29b36cd65db6fa2231ea3caa8f248229..7581cc1a053888c57f24f31735c82fe4cd5412e4 100644 (file)
--- a/cgit.h
+++ b/cgit.h
@@ -245,13 +245,13 @@ struct cgit_page {
        time_t modified;
        time_t expires;
        size_t size;
-       char *mimetype;
-       char *charset;
-       char *filename;
-       char *etag;
-       char *title;
+       const char *mimetype;
+       const char *charset;
+       const char *filename;
+       const char *etag;
+       const char *title;
        int status;
-       char *statusmsg;
+       const char *statusmsg;
 };
 
 struct cgit_environment {
index 4397a59e3809da6cf71c84ddd5b2c7d3afe94b2e..482d53a89f3d02d231f71fbee5d70874a618c1b4 100644 (file)
@@ -100,8 +100,9 @@ static int print_object(const unsigned char *sha1, const char *path)
        ctx.page.etag = sha1_to_hex(sha1);
        cgit_print_http_headers(&ctx);
        html_raw(buf, size);
+       /* If we allocated this, then casting away const is safe. */
        if (freemime)
-               free(ctx.page.mimetype);
+               free((char*) ctx.page.mimetype);
        return 1;
 }