Run AC_PROG_GCC_TRADITIONAL only when running AC_PROG_CC,

ie, not when user specifies --with-CC.  This corrects a scripting error
that I'm surprised hasn't been reported more often.  Moving the macro call
to the earlier point in the script is correct anyway: if -traditional is needed,
it should get added to CFLAGS before we start using the compiler for
other tests.

diff --git a/src/configure.in b/src/configure.in
index 861cc77f3047167c749f78c831718716fd30340b..eb7a23bab88ff497ca33de38f38acdb5f656617a 100644 (file)
--- a/src/configure.in
+++ b/src/configure.in
@@ -335,7 +335,10 @@ AC_ARG_WITH(CC,
        esac
        CC="$withval"
     ],
-    [   AC_PROG_CC])
+    [
+       AC_PROG_CC
+       AC_PROG_GCC_TRADITIONAL
+])
 
 if test "$CC" = "gcc"
 then
@@ -346,11 +349,9 @@ fi
 AC_SUBST(CC_VERSION)
 
 CPPFLAGS="$CPPFLAGS $PGSQL_CPPFLAGS"
-export CPPFLAGS
 echo "- setting CPPFLAGS=$CPPFLAGS"
 
 LDFLAGS="$LDFLAGS $PGSQL_LDFLAGS"
-export LDFLAGS
 echo "- setting LDFLAGS=$LDFLAGS"
 
 dnl Checks for programs.
@@ -668,7 +669,6 @@ main() {
        AC_MSG_RESULT(assuming not on target machine))
 
 dnl Checks for library functions.
-AC_PROG_GCC_TRADITIONAL
 AC_FUNC_MEMCMP
 AC_TYPE_SIGNAL
 AC_FUNC_VPRINTF