splat command verbose behavior

The splat command takes a verbose option which when set prints
the internal debug log for every test.  This is helpful when
tracking down a common failure, but for a rare failure the
volume of log data is distracting.

Therefore, the verbose option has been adjusted to allow only
printing the debug log on failure.  The legacy behavior is still
available by specifying the verbose option twice.  For example:

$ splat -t all:all     # Never print the debug log
$ splat -v -t all:all  # Only print debug log on failure
$ splat -vv -t all:all # Always print the debug log

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>

diff --git a/cmd/splat.c b/cmd/splat.c
index 2fa0c50c06e6c2082357ba496c6922772687d972..f4caa5639e36d15fff094d1e08cb268ad465ae14 100644 (file)
--- a/cmd/splat.c
+++ b/cmd/splat.c
@@ -431,7 +431,8 @@ static int test_run(cmd_args_t *args, test_t *test)
        fflush(stdout);
        free(cmd);
 
-       if (args->args_verbose) {
+       if ((args->args_verbose == 1 && rc) ||
+           (args->args_verbose >= 2)) {
                if ((rc = read(splatctl_fd, splat_buffer,
                               splat_buffer_size - 1)) < 0) {
                        fprintf(stdout, "Error reading results: %d\n", rc);