]> granicus.if.org Git - php/commitdiff
- MFH: Fixed memory leak in readline_callback_handler_remove()
authorFelipe Pena <felipe@php.net>
Fri, 21 Nov 2008 22:48:27 +0000 (22:48 +0000)
committerFelipe Pena <felipe@php.net>
Fri, 21 Nov 2008 22:48:27 +0000 (22:48 +0000)
ext/readline/readline.c

index 3a481dfa4c15e079498ef43735b3fa6b8244b9e6..9466fb0cbe33d3a67ba840fe13a55dc0961886fd 100644 (file)
@@ -516,7 +516,8 @@ PHP_FUNCTION(readline_callback_handler_install)
 
        if (_prepped_callback) {
                rl_callback_handler_remove();
-               zval_ptr_dtor(&_prepped_callback);
+               zval_dtor(_prepped_callback);
+               FREE_ZVAL(_prepped_callback);
        }
 
        MAKE_STD_ZVAL(_prepped_callback);
@@ -545,6 +546,7 @@ PHP_FUNCTION(readline_callback_handler_remove)
 {
        if (_prepped_callback) {
                rl_callback_handler_remove();
+               zval_dtor(_prepped_callback);
                FREE_ZVAL(_prepped_callback);
                _prepped_callback = 0;
                RETURN_TRUE;