bpo-30266: support "= None" pattern in AbstractContextManager (#1448)

contextlib.AbstractContextManager now supports anti-registration
by setting __enter__ = None or __exit__ = None, following the pattern
introduced in bpo-25958.

diff --git a/Lib/contextlib.py b/Lib/contextlib.py
index c53b35e8d5adaa00e2aa84c3baa222e4d2ed8726..962cedab490eb226571ef89d40bb4b0aa8064671 100644 (file)
--- a/Lib/contextlib.py
+++ b/Lib/contextlib.py
@@ -1,6 +1,7 @@
 """Utilities for with-statement contexts.  See PEP 343."""
 import abc
 import sys
+import _collections_abc
 from collections import deque
 from functools import wraps
 
@@ -25,9 +26,7 @@ class AbstractContextManager(abc.ABC):
     @classmethod
     def __subclasshook__(cls, C):
         if cls is AbstractContextManager:
-            if (any("__enter__" in B.__dict__ for B in C.__mro__) and
-                any("__exit__" in B.__dict__ for B in C.__mro__)):
-                return True
+            return _collections_abc._check_methods(C, "__enter__", "__exit__")
         return NotImplemented
 
 

diff --git a/Lib/test/test_contextlib.py b/Lib/test/test_contextlib.py
index b1a467d952da0fbb511c2d596dcd7d946f5a1e20..2301f759d80858e791c6f10d682cbaa45239dee7 100644 (file)
--- a/Lib/test/test_contextlib.py
+++ b/Lib/test/test_contextlib.py
@@ -44,6 +44,16 @@ class TestAbstractContextManager(unittest.TestCase):
 
         self.assertTrue(issubclass(DefaultEnter, AbstractContextManager))
 
+        class NoEnter(ManagerFromScratch):
+            __enter__ = None
+
+        self.assertFalse(issubclass(NoEnter, AbstractContextManager))
+
+        class NoExit(ManagerFromScratch):
+            __exit__ = None
+
+        self.assertFalse(issubclass(NoExit, AbstractContextManager))
+
 
 class ContextManagerTestCase(unittest.TestCase):
 

diff --git a/Misc/NEWS b/Misc/NEWS
index 7d31839e6734d8aaf58020e8c2af8f1c31f1206b..f126dd4e644211a0fe3aa745662f41cfb58e3f7b 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -410,6 +410,10 @@ Library
 - bpo-30048: Fixed ``Task.cancel()`` can be ignored when the task is
   running coroutine and the coroutine returned without any more ``await``.
 
+- bpo-30266: contextlib.AbstractContextManager now supports anti-registration
+  by setting __enter__ = None or __exit__ = None, following the pattern
+  introduced in bpo-25958. Patch by Jelle Zijlstra.
+
 - bpo-30340: Enhanced regular expressions optimization. This increased
   the performance of matching some patterns up to 25 times.