Close open files in case of failure (Amit)

diff --git a/ext/standard/proc_open.c b/ext/standard/proc_open.c
index 3806efa768899fb523a61c1a8e2c953f7112c64a..73ecf1bd82e96b1fd7e82f2b0a29691e863e8e96 100644 (file)
--- a/ext/standard/proc_open.c
+++ b/ext/standard/proc_open.c
@@ -755,6 +755,13 @@ PHP_FUNCTION(proc_open)
        }
        
        if (FALSE == newprocok) {
+               /* clean up all the descriptors */
+               for (i = 0; i < ndesc; i++) {
+                       CloseHandle(descriptors[i].childend);
+                       if (descriptors[i].parentend) {
+                               CloseHandle(descriptors[i].parentend);
+                       }
+               }
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "CreateProcess failed");
                goto exit_fail;
        }