Don't treat any WS as start of header

Check that the header occurs after \n, not other whitespace
characters.

diff --git a/ext/standard/http_fopen_wrapper.c b/ext/standard/http_fopen_wrapper.c
index 1248fd97bd7b7f524edce9c03a2692fd63240c22..5ac89d9ea282b544a911b0e95b09461f5bb7a836 100644 (file)
--- a/ext/standard/http_fopen_wrapper.c
+++ b/ext/standard/http_fopen_wrapper.c
@@ -109,7 +109,7 @@ static inline void strip_header(char *header_bag, char *lc_header_bag,
 static zend_bool check_has_header(const char *headers, const char *header) {
        const char *s = headers;
        while ((s = strstr(s, header))) {
-               if (s == headers || *(s-1) == '\r' || *(s-1) == '\n' || *(s-1) == '\t' || *(s-1) == ' ') {
+               if (s == headers || *(s-1) == '\n') {
                        return 1;
                }
                s++;
@@ -495,8 +495,7 @@ finish:
 
                        /* remove Proxy-Authorization header */
                        if (use_proxy && use_ssl && (s = strstr(t, "proxy-authorization:")) &&
-                           (s == t || *(s-1) == '\r' || *(s-1) == '\n' ||
-                                        *(s-1) == '\t' || *(s-1) == ' ')) {
+                           (s == t || *(s-1) == '\n')) {
                                char *p = s + sizeof("proxy-authorization:") - 1;
 
                                while (s > t && (*(s-1) == ' ' || *(s-1) == '\t')) s--;

diff --git a/ext/standard/tests/http/bug79265_2.phpt b/ext/standard/tests/http/bug79265_2.phpt
new file mode 100644 (file)
index 0000000..d2f5bc1
--- /dev/null
+++ b/ext/standard/tests/http/bug79265_2.phpt
@@ -0,0 +1,38 @@
+--TEST--
+Bug #79265 variation: "host:" not at start of header
+--INI--
+allow_url_fopen=1
+--SKIPIF--
+<?php require 'server.inc'; http_server_skipif('tcp://127.0.0.1:12342'); ?>
+--FILE--
+<?php
+require 'server.inc';
+
+$responses = array(
+    "data://text/plain,HTTP/1.0 200 OK\r\n\r\n",
+);
+
+$pid = http_server("tcp://127.0.0.1:12342", $responses, $output);
+
+$opts = array(
+  'http'=>array(
+    'method'=>"GET",
+    'header'=>"RandomHeader: host:8080\r\n" .
+              "Cookie: foo=bar\r\n"
+  )
+);
+$context = stream_context_create($opts);
+$fd = fopen('http://127.0.0.1:12342/', 'rb', false, $context);
+fseek($output, 0, SEEK_SET);
+echo stream_get_contents($output);
+fclose($fd);
+
+http_server_kill($pid);
+
+?>
+--EXPECT--
+GET / HTTP/1.0
+Host: 127.0.0.1:12342
+Connection: close
+RandomHeader: host:8080
+Cookie: foo=bar