]> granicus.if.org Git - llvm/commitdiff
[AVR] Fix a bug where asm operands are printed twice
authorDylan McKay <dylanmckay34@gmail.com>
Sun, 5 Feb 2017 10:42:49 +0000 (10:42 +0000)
committerDylan McKay <dylanmckay34@gmail.com>
Sun, 5 Feb 2017 10:42:49 +0000 (10:42 +0000)
We would unconditionally call printOperand, even if PrintAsmOperand
already printed the immediate.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@294121 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/AVR/AVRAsmPrinter.cpp
test/CodeGen/AVR/no-print-operand-twice.ll [new file with mode: 0644]

index 4afdd3a0ec089f8fde95fe5418775d11a5abeb93..50bb50b44f27b80dad552d22bdd88852c6e32db7 100644 (file)
@@ -130,7 +130,8 @@ bool AVRAsmPrinter::PrintAsmOperand(const MachineInstr *MI, unsigned OpNum,
     }
   }
 
-  printOperand(MI, OpNum, O);
+  if (Error)
+    printOperand(MI, OpNum, O);
 
   return false;
 }
diff --git a/test/CodeGen/AVR/no-print-operand-twice.ll b/test/CodeGen/AVR/no-print-operand-twice.ll
new file mode 100644 (file)
index 0000000..8326507
--- /dev/null
@@ -0,0 +1,8 @@
+; RUN: llc -no-integrated-as -march=avr < %s | FileCheck %s
+
+define void @test() {
+entry:
+; CHECK: /* result: 68719476738 */
+  tail call void asm sideeffect "/* result: ${0:c} */", "i,~{dirflag},~{fpsr},~{flags}"( i64 68719476738 )
+  ret void
+}