plug a trivial memory leak

diff --git a/macosx/PrefsController.m b/macosx/PrefsController.m
index b67d3e4207658962bb8e680b1ce2b527a3e1cf7f..71fa428eae86205edda3f076ce4b743a55ba9408 100644 (file)
--- a/macosx/PrefsController.m
+++ b/macosx/PrefsController.m
@@ -202,7 +202,7 @@
     [fQueueSeedField setIntValue: [fDefaults integerForKey: @"QueueSeedNumber"]];
     [fStalledField setIntValue: [fDefaults integerForKey: @"StalledMinutes"]];
     
-    //set proxy fields
+    //set proxy type
     [fProxyAddressField setStringValue: [fDefaults stringForKey: @"ProxyAddress"]];
     int proxyType;
     switch(tr_sessionGetProxyType(fHandle))
@@ -217,6 +217,8 @@
             proxyType = PROXY_HTTP;
     }
     [fProxyTypePopUp selectItemAtIndex: proxyType];
+    
+    //set proxy password - does NOT need to be released
     [fProxyPasswordField setStringValue: [NSString stringWithUTF8String: tr_sessionGetProxyPassword(fHandle)]];
     
     //set blocklist
@@ -224,7 +226,11 @@
     
     //set rpc port
     [fRPCPortField setIntValue: [fDefaults integerForKey: @"RPCPort"]];
-    [fRPCPasswordField setStringValue: [NSString stringWithUTF8String: tr_sessionGetRPCPassword(fHandle)]];
+    
+    //set rpc password - has to be released
+    const char * rpcPassword = tr_sessionGetRPCPassword(fHandle);
+    [fRPCPasswordField setStringValue: [NSString stringWithUTF8String: rpcPassword]];
+    tr_free(rpcPassword);
 }
 
 - (void) setUpdater: (SUUpdater *) updater