]> granicus.if.org Git - python/commitdiff
Fix null pointer dereferencing in structmember.c PyMember_SetOne() for T_CHAR. _PyUni...
authorChristian Heimes <christian@cheimes.de>
Tue, 11 Sep 2012 15:30:53 +0000 (17:30 +0200)
committerChristian Heimes <christian@cheimes.de>
Tue, 11 Sep 2012 15:30:53 +0000 (17:30 +0200)
Python/structmember.c

index ddedea5419c4f569e06baa2111e6efcd8f2ff8fd..af0296d802fd81cab89ebdb20f24d44c58636bb1 100644 (file)
@@ -254,12 +254,8 @@ PyMember_SetOne(char *addr, PyMemberDef *l, PyObject *v)
         char *string;
         Py_ssize_t len;
 
-        if (!PyUnicode_Check(v)) {
-            PyErr_BadArgument();
-            return -1;
-        }
         string = _PyUnicode_AsStringAndSize(v, &len);
-        if (len != 1) {
+        if (string == NULL || len != 1) {
             PyErr_BadArgument();
             return -1;
         }