clang-tidy: default init variables

Found with modernize-use-default-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>

diff --git a/matroska/KaxBlock.h b/matroska/KaxBlock.h
index f87d0c6b001614a4d567480623212d40d302d1b3..bb2275a20417a45950072aaefc1ca4871780867b 100644 (file)
--- a/matroska/KaxBlock.h
+++ b/matroska/KaxBlock.h
@@ -201,8 +201,8 @@ DECLARE_MKX_MASTER(KaxBlockGroup)
     const KaxCluster *GetParentCluster() const { return ParentCluster; }
 
   protected:
-    KaxCluster * ParentCluster;
-    const KaxTrackEntry * ParentTrack;
+    KaxCluster * ParentCluster{nullptr};
+    const KaxTrackEntry * ParentTrack{nullptr};
 };
 
 class MATROSKA_DLL_API KaxInternalBlock : public EbmlBinary {
@@ -376,7 +376,7 @@ DECLARE_MKX_BINARY_CONS(KaxBlockVirtual)
     uint16 TrackNumber;
     binary DataBlock[5];
 
-    const KaxCluster * ParentCluster;
+    const KaxCluster * ParentCluster{nullptr};
 };
 
 END_LIBMATROSKA_NAMESPACE

diff --git a/matroska/KaxBlockData.h b/matroska/KaxBlockData.h
index c8e86b3136407e6ce774cf44c5b570c3ea75f6c4..eb977cee61900c917307bd3a51487ddbfc99baf2 100644 (file)
--- a/matroska/KaxBlockData.h
+++ b/matroska/KaxBlockData.h
@@ -62,10 +62,10 @@ DECLARE_MKX_SINTEGER_CONS(KaxReferenceBlock)
     void SetReferencedTimecode(int64 refTimecode) {*static_cast<EbmlSInteger*>(this) = refTimecode; bTimecodeSet = true;};
 
   protected:
-    const KaxBlockBlob * RefdBlock;
-    const KaxBlockGroup * ParentBlock;
-    bool bTimecodeSet;
-        bool bOurBlob;
+    const KaxBlockBlob * RefdBlock{nullptr};
+    const KaxBlockGroup * ParentBlock{nullptr};
+    bool bTimecodeSet{false};
+        bool bOurBlob{false};
         void FreeBlob();
 };
 

diff --git a/matroska/KaxCluster.h b/matroska/KaxCluster.h
index 274cd9e401c1eb72e18ad10d85c8beb6c2e74699..7fa50474fde6985d8cbbaf64808119222ddb892e 100644 (file)
--- a/matroska/KaxCluster.h
+++ b/matroska/KaxCluster.h
@@ -137,16 +137,16 @@ DECLARE_MKX_MASTER_CONS(KaxCluster)
   protected:
     KaxBlockBlob     * currentNewBlob;
     std::vector<KaxBlockBlob*> Blobs;
-    KaxBlockGroup    * currentNewBlock;
-    const KaxSegment * ParentSegment;
+    KaxBlockGroup    * currentNewBlock{nullptr};
+    const KaxSegment * ParentSegment{nullptr};
 
     uint64 MinTimecode, MaxTimecode, PreviousTimecode;
     int64  TimecodeScale;
 
-    bool bFirstFrameInside; // used to speed research
-    bool bPreviousTimecodeIsSet;
-    bool bTimecodeScaleIsSet;
-    bool bSilentTracksUsed;
+    bool bFirstFrameInside{false}; // used to speed research
+    bool bPreviousTimecodeIsSet{false};
+    bool bTimecodeScaleIsSet{false};
+    bool bSilentTracksUsed{false};
 
     /*!
       \note method used internally

diff --git a/matroska/KaxTracks.h b/matroska/KaxTracks.h
index d820bceadebf2ffe0b3da05650ae741a15dcd5b8..cbe5db39c7e556c1b74bfffd8daa3966c20439d7 100644 (file)
--- a/matroska/KaxTracks.h
+++ b/matroska/KaxTracks.h
@@ -69,7 +69,7 @@ DECLARE_MKX_MASTER(KaxTrackEntry)
     }
 
   protected:
-    bool   bGlobalTimecodeScaleIsSet;
+    bool   bGlobalTimecodeScaleIsSet{false};
     uint64 mGlobalTimecodeScale;
 };
 

diff --git a/src/KaxBlock.cpp b/src/KaxBlock.cpp
index 44bdf304b35fe59b27367b7ac766ec468e40c6ef..ace92d4bd3125851c567781b2f7648cc0de09d93 100644 (file)
--- a/src/KaxBlock.cpp
+++ b/src/KaxBlock.cpp
@@ -101,8 +101,6 @@ KaxInternalBlock::KaxInternalBlock(const KaxInternalBlock & ElementToClone)
 
 KaxBlockGroup::KaxBlockGroup(EBML_EXTRA_DEF)
   :EbmlMaster(EBML_CLASS_SEMCONTEXT(KaxBlockGroup) EBML_DEF_SEP EBML_EXTRA_CALL)
-  ,ParentCluster(nullptr)
-  ,ParentTrack(nullptr)
 {}
 
 /*!

diff --git a/src/KaxBlockData.cpp b/src/KaxBlockData.cpp
index f17ed00b544fb2c5ab7b2a5b24a5a50f276b7231..de9b93fa759c7a39560efb38e960901520c4a58f 100644 (file)
--- a/src/KaxBlockData.cpp
+++ b/src/KaxBlockData.cpp
@@ -51,19 +51,13 @@ const KaxBlockBlob & KaxReferenceBlock::RefBlock() const
 KaxReferenceBlock::KaxReferenceBlock(EBML_EXTRA_DEF)
   :EBML_DEF_SINTEGER(KaxReferenceBlock)EBML_DEF_SEP
   RefdBlock(nullptr)
-  ,ParentBlock(nullptr)
-  ,bTimecodeSet(false)
-  ,bOurBlob(false)
 {
   bTimecodeSet = false;
 }
 
 KaxReferenceBlock::KaxReferenceBlock(const KaxReferenceBlock & ElementToClone)
   :EbmlSInteger(ElementToClone)
-  ,RefdBlock(nullptr)
-  ,ParentBlock(nullptr)
   ,bTimecodeSet(ElementToClone.bTimecodeSet)
-  ,bOurBlob(false)
 {
 }
 

diff --git a/src/KaxCluster.cpp b/src/KaxCluster.cpp
index e8b61a5193b4c0a758532847a805e3a4244374f6..0a7a91e5c58b9930fbdbea9e6126dcde9c432a43 100644 (file)
--- a/src/KaxCluster.cpp
+++ b/src/KaxCluster.cpp
@@ -41,12 +41,6 @@ START_LIBMATROSKA_NAMESPACE
 
 KaxCluster::KaxCluster(EBML_EXTRA_DEF)
   :EbmlMaster(EBML_CLASS_SEMCONTEXT(KaxCluster) EBML_DEF_SEP EBML_EXTRA_CALL)
-  ,currentNewBlock(nullptr)
-  ,ParentSegment(nullptr)
-  ,bFirstFrameInside(false)
-  ,bPreviousTimecodeIsSet(false)
-  ,bTimecodeScaleIsSet(false)
-  ,bSilentTracksUsed(false)
 {}
 
 KaxCluster::KaxCluster(const KaxCluster & ElementToClone)

diff --git a/src/KaxTracks.cpp b/src/KaxTracks.cpp
index 85a1baaec0bfe16e57892a585e97ca30a21f3143..bc18eff135c4affc258c43bfd7933a3486889cee 100644 (file)
--- a/src/KaxTracks.cpp
+++ b/src/KaxTracks.cpp
@@ -42,7 +42,6 @@ START_LIBMATROSKA_NAMESPACE
 
 KaxTrackEntry::KaxTrackEntry(EBML_EXTRA_DEF)
   :EbmlMaster(EBML_CLASS_SEMCONTEXT(KaxTrackEntry) EBML_DEF_SEP EBML_EXTRA_CALL)
-  ,bGlobalTimecodeScaleIsSet(false)
 {}
 
 void KaxTrackEntry::EnableLacing(bool bEnable)