bpo-36801: Temporarily fix regression in writer.drain() (#13330)
authorAndrew Svetlov <andrew.svetlov@gmail.com>
Tue, 14 May 2019 21:39:13 +0000 (00:39 +0300)
committerGitHub <noreply@github.com>
Tue, 14 May 2019 21:39:13 +0000 (00:39 +0300)
Lib/asyncio/streams.py
Lib/test/test_asyncio/test_streams.py

index 146a33818d952a0a1e944db4e5d04d809213adc9..2f0cbfdbe852d180e98559654fb955a8b9f26ca9 100644 (file)
@@ -439,9 +439,7 @@ class StreamWriter:
             # Wait for protocol.connection_lost() call
             # Raise connection closing error if any,
             # ConnectionResetError otherwise
-            fut = self._protocol._get_close_waiter(self)
-            await fut
-            raise ConnectionResetError('Connection lost')
+            await sleep(0)
         await self._protocol._drain_helper()
 
 
index 8d6a1d26ac1934e8d4b62f6488d6a3c208c4ff3c..258d8a7f7fdfcd4b2b574e054d88137d34c9d3f7 100644 (file)
@@ -109,29 +109,6 @@ class StreamTests(test_utils.TestCase):
 
             self._basetest_open_connection_no_loop_ssl(conn_fut)
 
-    @unittest.skipIf(ssl is None, 'No ssl module')
-    def test_drain_on_closed_writer_ssl(self):
-
-        async def inner(httpd):
-            reader, writer = await asyncio.open_connection(
-                *httpd.address,
-                ssl=test_utils.dummy_ssl_context())
-
-            messages = []
-            self.loop.set_exception_handler(lambda loop, ctx: messages.append(ctx))
-            writer.write(b'GET / HTTP/1.0\r\n\r\n')
-            data = await reader.read()
-            self.assertTrue(data.endswith(b'\r\n\r\nTest message'))
-
-            writer.close()
-            with self.assertRaises(ConnectionResetError):
-                await writer.drain()
-
-            self.assertEqual(messages, [])
-
-        with test_utils.run_test_server(use_ssl=True) as httpd:
-            self.loop.run_until_complete(inner(httpd))
-
     def _basetest_open_connection_error(self, open_connection_fut):
         messages = []
         self.loop.set_exception_handler(lambda loop, ctx: messages.append(ctx))