SF bug http://sourceforge.net/bugs/?func=detailbug&bug_id=130242&group_id=5470

SF patch http://sourceforge.net/patch/?func=detailpatch&patch_id=103453&group_id=5470
PyMember_Set of T_CHAR always raises exception.
Unfortunately, this is a use of a C API function that Python itself never makes, so
there's no .py test I can check in to verify this stays fixed.  But the fault in the
code is obvious, and Dave Cole's patch just as obviously fixes it.

diff --git a/Misc/ACKS b/Misc/ACKS
index 95685475af525891c7f2708b501834f0f012bd9f..554203fefc8749d9e6d4ac16f328efe81ad34d9c 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -72,6 +72,7 @@ Tom Christiansen
 Vadim Chugunov
 Mike Clarkson
 Steve Clift
+Dave Cole
 Jeffery Collins
 Matt Conway
 Scott Cotton

diff --git a/Python/structmember.c b/Python/structmember.c
index bc1ba251acceb4d6f0ede2b271ae2908a4e94cec..e155a6b49f8c6f60ecaf7bfb9a4ba2a68112356e 100644 (file)
--- a/Python/structmember.c
+++ b/Python/structmember.c
@@ -231,6 +231,7 @@ PyMember_Set(char *addr, struct memberlist *mlist, char *name, PyObject *v)
                                        PyErr_BadArgument();
                                        return -1;
                                }
+                               break;
                        default:
                                PyErr_SetString(PyExc_SystemError,
                                                "bad memberlist type");