]> granicus.if.org Git - clang/commitdiff
Add a comment/FIXME to an earlier change.
authorSteve Naroff <snaroff@apple.com>
Mon, 11 Feb 2008 02:42:07 +0000 (02:42 +0000)
committerSteve Naroff <snaroff@apple.com>
Mon, 11 Feb 2008 02:42:07 +0000 (02:42 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@46947 91177308-0d34-0410-b5e6-96231b3b80d8

Sema/SemaDecl.cpp

index c6f1203e6822a7c0a90de8502d7633f4d98f88e1..c427a81306733366d99d2f49b9cbe5850e1be3fd 100644 (file)
@@ -527,7 +527,11 @@ bool Sema::CheckInitializerListTypes(InitListExpr*& IList, QualType &DeclType,
       } else {
         RecordDecl* structDecl = DeclType->getAsRecordType()->getDecl();
         
-        // If the record is invalid, it's members can't be trusted. 
+        // If the record is invalid, it's members can't be trusted.
+        // FIXME: I'd like to "fix" this at a higher level. That is, we should
+        // never get here if the struct decl is invalid. Considering a
+        // change to Type::isIncompleteType(). Until this happens, the 
+        // following check is certainly better than crashing.
         if (structDecl->isInvalidDecl())
           return true;