Fixing MSVC warning: "warning C4373: 'blah': virtual function overrides 'blah', previ...

This warning is basically useless because the "previous versions" being referred to is MSVC 2005 and earlier, and we obviously do not care about them. However, this warning isn't particularly chatty (I don't recall ever seeing it previously), and it has the opportunity to point out cases where the cv-qualifiers differ unintentionally (like this case), so I am leaving it enabled for now.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216267 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
index 2e655897220c6b36205fad6491084ff45c4540a0..4998ca38834857b764c090353a34601d5af46976 100644 (file)
--- a/lib/Basic/Targets.cpp
+++ b/lib/Basic/Targets.cpp
@@ -4146,8 +4146,7 @@ public:
     return R;
   }
   bool
-  validateConstraintModifier(StringRef Constraint, const char Modifier,
-                             unsigned Size,
+  validateConstraintModifier(StringRef Constraint, char Modifier, unsigned Size,
                              std::string &SuggestedModifier) const override {
     bool isOutput = (Constraint[0] == '=');
     bool isInOut = (Constraint[0] == '+');
@@ -4595,8 +4594,7 @@ public:
   }
 
   bool
-  validateConstraintModifier(StringRef Constraint, const char Modifier,
-                             unsigned Size,
+  validateConstraintModifier(StringRef Constraint, char Modifier, unsigned Size,
                              std::string &SuggestedModifier) const override {
     // Strip off constraint modifiers.
     while (Constraint[0] == '=' || Constraint[0] == '+' || Constraint[0] == '&')