Joe Malicki filed bug report #1871269

(http://curl.haxx.se/bug/view.cgi?id=1871269) and we could fix his hang-
problem that occurred when doing a large HTTP POST request with the
response-body read from a callback.

diff --git a/CHANGES b/CHANGES
index e52589147e4ab63aaac47e3604636dc05a50efa6..560f1791b17ef7a768daefaef68a1a5d237d6512 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,12 @@
 
                                   Changelog
 
+Daniel S (14 Jan 2008)
+- Joe Malicki filed bug report #1871269
+  (http://curl.haxx.se/bug/view.cgi?id=1871269) and we could fix his hang-
+  problem that occurred when doing a large HTTP POST request with the
+  response-body read from a callback.
+
 Daniel S (12 Jan 2008)
 - I re-arranged the curl --help output. All the options are now sorted on
   their long option names and all descriptions are one-liners.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 58e6def274b2df71fce3f21671808f9ff4e5514b..10d05e71f5b055d526c045f41a2c06d590aa9d0f 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -52,6 +52,7 @@ This release includes the following bugfixes:
  o allows more spaces in WWW/Proxy-Authenticate: headers
  o curl-config --libs skips /usr/lib64
  o range support for file:// transfers
+ o libcurl hang with huge POST request and request-body read from callback
 
 This release includes the following known bugs:
 
@@ -74,6 +75,7 @@ advice from friends like these:
  Emil Romanus, Alessandro Vesely, Ray Pekowski, Spacen Jasset, Andrew Moise,
  Gilles Blanc, David Wright, Vikram Saxena, Mateusz Loskot, Gary Maxwell,
  Dmitry Kurochkin, Mohun Biswas, Richard Atterer, Maxim Perenesenko,
- Daniel Egger, Jeff Johnson, Nikitinskit Dmitriy, Georg Lippitsch, Eric Landes
+ Daniel Egger, Jeff Johnson, Nikitinskit Dmitriy, Georg Lippitsch, Eric Landes,
+ Joe Malicki
  
         Thanks! (and sorry if I forgot to mention someone)

diff --git a/lib/http.c b/lib/http.c
index fd58c06cc69afeb3a6e3a6e14b575401bf70f267..1dcdc0f91ffcaff0edc2f40ba9fadd27b48b24b2 100644 (file)
--- a/lib/http.c
+++ b/lib/http.c
@@ -2705,8 +2705,10 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
           /* set the pointer to mark that we will send the post body using the
              read callback, but only if we're not in authenticate
              negotiation  */
-          if(!conn->bits.authneg)
+          if(!conn->bits.authneg) {
             http->postdata = (char *)&http->postdata;
+            http->postsize = postsize;
+          }
         }
       }
       /* issue the request */